chore: upgrade golangci-lint to v2 (release-2.14)

[thevilledev]

Prep for Go version upgrade in #23294 by upgrading golangci-lint to the latest version for the release-2.14 branch.

• Disabled staticcheck related rules which were causing hundreds of linting errors, requiring breaking changes and manual labor. See diff for full list. My suggestion is that these could be improved in separate PRs one by one. Many of these are automatically fixable.
• Disabled certain testifylint rules which were also auto-fixable.

Only tests required code changes:

• Removed a nolint reference to an inactive linter ("structcheck")
• Fixed a misuse of assert.ElementsMatch()

Separate commits in this PR hopefully help the review process.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.33%. Comparing base (14fa0e0) to head (c9fe32f).
⚠️ Report is 18 commits behind head on release-2.14.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-2.14   #23305      +/-   ##
================================================
+ Coverage         55.30%   55.33%   +0.02%     
================================================
  Files               339      339              
  Lines             57361    57361              
================================================
+ Hits              31726    31738      +12     
+ Misses            22941    22937       -4     
+ Partials           2694     2686       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[crenshaw-dev]

Does the upgrade require enabling new linters? i.e. could we make this PR more minimal?

[thevilledev]

Sure, I can disable more rules if we want to keep changes to the minimum. I believe the default set changed with v2 for staticcheck specifically

[crenshaw-dev]

Ah sure. Yeah I'd like to do whatever is the minimum necessary to unblock the go upgrade.

[thevilledev]

Messed up DCO for the previous run but tests passed. I think we are close :)

[thevilledev]

@crenshaw-dev feedback welcome on the current approach! Tests pass with the v2 linter now, with minimal changes

[crenshaw-dev]

looks great, thanks!