Skip to content

Conversation

@agaudreault
Copy link
Member

Cherry pick of #23133

Signed-off-by: Jagpreet Singh Tamber [email protected]
Signed-off-by: Alexandre Gaudreault [email protected]<!--
Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
-->

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

jagpreetstamber and others added 2 commits June 4, 2025 12:25
…on token expiry. (argoproj#23133)

Signed-off-by: Jagpreet Singh Tamber <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault requested a review from a team as a code owner June 4, 2025 16:38
@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.97%. Comparing base (001848e) to head (3ee5c88).
⚠️ Report is 42 commits behind head on release-3.0.

Files with missing lines Patch % Lines
util/helm/creds.go 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-3.0   #23264      +/-   ##
===============================================
+ Coverage        55.88%   55.97%   +0.09%     
===============================================
  Files              343      343              
  Lines            57395    57422      +27     
===============================================
+ Hits             32075    32143      +68     
+ Misses           22663    22635      -28     
+ Partials          2657     2644      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agaudreault agaudreault merged commit f72ac78 into argoproj:release-3.0 Jun 4, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants