chore: enable lint for unused private fields

[crenshaw-dev]

This lint rule seems mostly very good. It found a bunch of unnecessary code.

The only false positives were two structs that have fields that are being used to make unique map keys.

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[crenshaw-dev]

Setting this was actually a no-op. Need to investigate more. Maybe we switched from an in-memory cache to a Redis cache and just didn't update the code?

[crenshaw-dev]

This PR replaced the redis-based failures counter with an in-memory solution that doesn't have a configurable expiration: #5477

Not going to reevaluate that decision for this PR, just going to remove the dead code.

[codecov]

Codecov Report

❌ Patch coverage is 92.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.99%. Comparing base (ea97dec) to head (5da1d17).
⚠️ Report is 421 commits behind head on master.

Files with missing lines	Patch %	Lines
...plicationset/services/scm_provider/azure_devops.go	0.00%	1 Missing ⚠️
cmd/argocd/commands/admin/app.go	0.00%	1 Missing ⚠️
cmd/argocd/commands/headless/headless.go	0.00%	1 Missing ⚠️
server/application/terminal.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #23242      +/-   ##
==========================================
- Coverage   60.02%   59.99%   -0.03%     
==========================================
  Files         342      341       -1     
  Lines       57870    57818      -52     
==========================================
- Hits        34736    34689      -47     
+ Misses      20352    20346       -6     
- Partials     2782     2783       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[crenshaw-dev]

These fields aren't read, so this method doesn't do anything.

[ranakan19]

Looks Good, Thanks for the changes and leaving some comments on the reviews, they were helpful.

Quite a cleanup of the ArgoCDRepoServer struct! 👏🏽

[crenshaw-dev]

@ranakan19 thanks! Yeah the cleanup on ArgoCDRepoServer made me very happy :-D

[ishitasequeira]

LGTM!! Thanks for the amazing cleanup @crenshaw-dev !! 🙌 🚀