Skip to content

Conversation

@daengdaengLee
Copy link
Member

Fixes #22879

Hello everyone, especially Mac users.

Here’s an update:
The default values for CGO_FLAG and STATIC_BUILD are now set dynamically, depending on whether your local environment is macOS.
This means you no longer need to set them manually for local builds or tests.
The system will automatically detect if you're on a Mac and apply the appropriate defaults.

Thanks!

Checklist:

  • [b,c] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [o] The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • [o] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • [o] I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • [o] I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@daengdaengLee daengdaengLee requested a review from a team as a code owner May 28, 2025 13:35
@bunnyshell
Copy link

bunnyshell bot commented May 28, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.99%. Comparing base (18ce5c2) to head (ce1e1b5).
⚠️ Report is 435 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #23182   +/-   ##
=======================================
  Coverage   59.98%   59.99%           
=======================================
  Files         343      343           
  Lines       57890    57890           
=======================================
+ Hits        34727    34729    +2     
+ Misses      20381    20379    -2     
  Partials     2782     2782           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gdsoumya gdsoumya merged commit 76f80b3 into argoproj:master Jun 2, 2025
28 checks passed
@daengdaengLee daengdaengLee deleted the issue-22879 branch June 3, 2025 08:45
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
…env is local Mac (argoproj#23182)

Signed-off-by: daengdaengLee <[email protected]>
Signed-off-by: dsuhinin <[email protected]>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
…env is local Mac (argoproj#23182)

Signed-off-by: daengdaengLee <[email protected]>
Signed-off-by: dsuhinin <[email protected]>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
…env is local Mac (argoproj#23182)

Signed-off-by: daengdaengLee <[email protected]>
Signed-off-by: enneitex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make cli-local fails with undefined: accessor.New for azure-sdk-for-go

3 participants