Skip to content

Conversation

@codesenju
Copy link
Contributor

This PR fixes various typos in the documentation.
No breaking changes or new requirements are introduced.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@codesenju codesenju requested review from a team as code owners May 26, 2025 01:21
@bunnyshell
Copy link

bunnyshell bot commented May 26, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codesenju codesenju changed the title Bulk typo fix docs: Bulk typo fix May 26, 2025
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Can you fix the codegen checks?

crenshaw-dev
crenshaw-dev previously approved these changes May 27, 2025
@crenshaw-dev
Copy link
Member

Thanks @codesenju! Can you run codegen and push?

@crenshaw-dev
Copy link
Member

Looks like the commit history got messed up. (Happens to me too when I follow the DCO instructions to fix the failed check.) Can you force-push with a clean history?

@crenshaw-dev crenshaw-dev dismissed their stale review May 27, 2025 22:28

Commit history needs cleanup

@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@0205eaf). Learn more about missing BASE report.
⚠️ Report is 442 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #23144   +/-   ##
=========================================
  Coverage          ?   60.07%           
=========================================
  Files             ?      343           
  Lines             ?    57890           
  Branches          ?        0           
=========================================
  Hits              ?    34777           
  Misses            ?    20340           
  Partials          ?     2773           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for fixing the codegen, please run make codegen-local

Signed-off-by: Codesenju <[email protected]>

fix typo use singular

Signed-off-by: Codesenju <[email protected]>

docs: fix a typo in config-management-plugins.md (#23172)

Signed-off-by: Pavel Skuratovich <[email protected]>
Signed-off-by: Codesenju <[email protected]>

docs: fix true source

docs: reverted because unable to found source
@crenshaw-dev crenshaw-dev merged commit f43523a into argoproj:master May 29, 2025
28 checks passed
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants