Skip to content

fix(test): #23137 removed left over file that breaks subsequent make test run. #23138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

fix(test): #23137 removed left over file that breaks subsequent make test run. #23138

merged 1 commit into from
May 27, 2025

Conversation

@EricFortin
Copy link
Contributor

@EricFortin EricFortin commented May 24, 2025

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Running make test was leaving a file behind and it was making subsequent run to fail. Added removal in latest test cleanup like originally intended: 5fdbe20#diff-42504deced8cf9ed534a90ad3eec63888b14b2e1b6586e2e938b18d305e3af3cR1181

Closes [#23137]

@EricFortin EricFortin requested a review from a team as a code owner May 24, 2025 18:44
@bunnyshell
Copy link

bunnyshell bot commented May 24, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@EricFortin EricFortin force-pushed the fix/make-test-fail branch from e620b69 to ec906f1 Compare May 24, 2025 18:45
@codecov
Copy link

codecov bot commented May 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.01%. Comparing base (b6d9d6d) to head (ec906f1).
⚠️ Report is 434 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #23138      +/-   ##
==========================================
+ Coverage   59.99%   60.01%   +0.01%     
==========================================
  Files         343      343              
  Lines       57888    57888              
==========================================
+ Hits        34732    34743      +11     
+ Misses      20374    20366       -8     
+ Partials     2782     2779       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nitishfy
nitishfy approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crenshaw-dev
crenshaw-dev approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crenshaw-dev crenshaw-dev merged commit 6ef9713 into argoproj:master May 27, 2025
28 checks passed
@EricFortin EricFortin deleted the fix/make-test-fail branch May 27, 2025 14:58
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
@EricFortin @tylerrosnett
fix(test): argoproj#23137 removed left over file that breaks subseque…
a42280c 
…nt make test run. (argoproj#23138)

Signed-off-by: Eric Fortin <[email protected]>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@EricFortin @chansuke
fix(test): argoproj#23137 removed left over file that breaks subseque…
49feba5 
…nt make test run. (argoproj#23138)

Signed-off-by: Eric Fortin <[email protected]>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@EricFortin @dsuhinin
fix(test): argoproj#23137 removed left over file that breaks subseque…
d307b94 
…nt make test run. (argoproj#23138)

Signed-off-by: Eric Fortin <[email protected]>
Signed-off-by: dsuhinin <[email protected]>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@EricFortin @dsuhinin
fix(test): argoproj#23137 removed left over file that breaks subseque…
7e37f48 
…nt make test run. (argoproj#23138)

Signed-off-by: Eric Fortin <[email protected]>
Signed-off-by: dsuhinin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

@nitishfy nitishfy nitishfy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EricFortin @crenshaw-dev @nitishfy