Skip to content

Conversation

@pjiang-dev
Copy link
Contributor

@pjiang-dev pjiang-dev commented May 20, 2025

This fixes #23016

The issue was removed fields will not show up in the diff when using Server-Side diff

Change in Git:
Screenshot 2025-05-20 at 10 17 41 AM

Before fix:
Screenshot 2025-05-20 at 10 16 18 AM

After fix:
Screenshot 2025-05-16 at 12 23 59 AM

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell
Copy link

bunnyshell bot commented May 20, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.01%. Comparing base (db9c82a) to head (e3869d2).
⚠️ Report is 562 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #23066      +/-   ##
==========================================
+ Coverage   56.06%   60.01%   +3.94%     
==========================================
  Files         343      343              
  Lines       57545    57830     +285     
==========================================
+ Hits        32262    34706    +2444     
+ Misses      22633    20354    -2279     
- Partials     2650     2770     +120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pjiang-dev pjiang-dev marked this pull request as ready for review May 20, 2025 18:34
@pjiang-dev pjiang-dev requested a review from a team as a code owner May 20, 2025 18:34
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) May 20, 2025 18:36
@crenshaw-dev crenshaw-dev merged commit 4f35f7f into argoproj:master May 20, 2025
27 checks passed
@pjiang-dev
Copy link
Contributor Author

/cherry-pick release-3.0

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 4f35f7f09a98e323d23faaaa93ccbbfe9cc3a986 into temp-cherry-pick-fe6817-release-3.0

pjiang-dev added a commit to pjiang-dev/argo-cd that referenced this pull request May 20, 2025
@pjiang-dev pjiang-dev mentioned this pull request May 20, 2025
14 tasks
@pjiang-dev
Copy link
Contributor Author

/cherry-pick release-2.14

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 4f35f7f09a98e323d23faaaa93ccbbfe9cc3a986 into temp-cherry-pick-fe6817-release-2.14

pjiang-dev added a commit to pjiang-dev/argo-cd that referenced this pull request May 21, 2025
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 24, 2025
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server-Side diff does not show removal of fields

2 participants