fix(webhook): Fix panic when web URL string is empty in webhook payload #23042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: anandf <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23042 +/- ##
==========================================
+ Coverage 60.02% 60.05% +0.03%
==========================================
Files 343 343
Lines 57846 57847 +1
==========================================
+ Hits 34723 34742 +19
+ Misses 20353 20337 -16
+ Partials 2770 2768 -2 ☔ View full report in Codecov by Sentry. |
Member
|
Tagging @reggie-k for reviews on this PR. |
nitishfy
approved these changes
May 20, 2025
Member
nitishfy
left a comment
nitishfy
left a comment
There was a problem hiding this comment.
Tested it locally and working well, thanks!
crenshaw-dev
approved these changes
May 20, 2025
LyhengTep
pushed a commit
to LyhengTep/argo-cd
that referenced
this pull request
May 24, 2025
…ad (argoproj#23042) Signed-off-by: anandf <[email protected]> Signed-off-by: Lyheng <[email protected]>
tylerrosnett
pushed a commit
to StateFarmIns/argo-cd
that referenced
this pull request
May 27, 2025
…ad (argoproj#23042) Signed-off-by: anandf <[email protected]>
chansuke
pushed a commit
to chansuke/argo-cd
that referenced
this pull request
Jun 4, 2025
…ad (argoproj#23042) Signed-off-by: anandf <[email protected]>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
…ad (argoproj#23042) Signed-off-by: anandf <[email protected]> Signed-off-by: dsuhinin <[email protected]>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
…ad (argoproj#23042) Signed-off-by: anandf <[email protected]> Signed-off-by: dsuhinin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23024
Need to be cherry pickedd in release branches of v3.0, v2.14, v2.13
Checklist: