chore: upgrade Go from 1.24.1 to 1.24.3 #23026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates Go version across all workflows, Dockerfile and go.mod to address an os.Root related security fix. Signed-off-by: Ville Vesilehto <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23026 +/- ##
==========================================
+ Coverage 60.01% 60.03% +0.02%
==========================================
Files 343 343
Lines 57846 57846
==========================================
+ Hits 34717 34730 +13
+ Misses 20361 20346 -15
- Partials 2768 2770 +2 ☔ View full report in Codecov by Sentry. |
nitishfy
approved these changes
May 19, 2025
ranakan19
pushed a commit
to ranakan19/argo-cd
that referenced
this pull request
May 20, 2025
Signed-off-by: Ville Vesilehto <[email protected]> Signed-off-by: Kanika Rana <[email protected]>
olivergondza
pushed a commit
to olivergondza/argo-cd
that referenced
this pull request
May 20, 2025
Signed-off-by: Ville Vesilehto <[email protected]> Signed-off-by: Oliver Gondža <[email protected]>
LyhengTep
pushed a commit
to LyhengTep/argo-cd
that referenced
this pull request
May 24, 2025
Signed-off-by: Ville Vesilehto <[email protected]> Signed-off-by: Lyheng <[email protected]>
tylerrosnett
pushed a commit
to StateFarmIns/argo-cd
that referenced
this pull request
May 27, 2025
Signed-off-by: Ville Vesilehto <[email protected]>
3 tasks
chansuke
pushed a commit
to chansuke/argo-cd
that referenced
this pull request
Jun 4, 2025
Signed-off-by: Ville Vesilehto <[email protected]>
Member
|
/cherry-pick release-3.0 |
Member
|
@thevilledev would you mind manually raising the cherry pick PRs for v2.14 and v3.0? |
Contributor
Author
|
@nitishfy sure thing, I'll do that later today! |
Contributor
Author
|
@blakepettersson and @nitishfy, just realised Go 1.24.4 will be released tomorrow. It includes one private (yet to be disclosed) CVE fix, so upgrading might be a high priority thing tomorrow. Shall I open those 1.24.4 upgrades for all affected branches then instead of 1.24.3? |
Member
|
@thevilledev I'm totally fine with waiting for that release |
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
Signed-off-by: Ville Vesilehto <[email protected]> Signed-off-by: dsuhinin <[email protected]>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
Signed-off-by: Ville Vesilehto <[email protected]> Signed-off-by: dsuhinin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates Go version across all workflows, Dockerfile and go.mod to address an
os.Rootrelated security fix.This functionality is being used by #22936 (merged) and #22956 (draft PR).
For older ArgoCD release branches it seems there's no need to cherry-pick, as they operate on older Go versions than 1.24 (where
os.Rootwas originally introduced).Checklist