Skip to content

Conversation

@dnrce
Copy link
Contributor

@dnrce dnrce commented May 14, 2025

Under Settings > Appearance, update the theme selector label from "Dark Theme" to "Theme."

Previously this field was a toggle for whether "Dark Theme" was on or off, so the label "Dark Theme" was clear. Once the "auto" theme was added and this was made a selector with values "Light"/"Dark"/"Auto", it was possible to set "Dark Theme = Light" which no longer made sense. This updates the label to simply "Theme," to fit the selector.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell
Copy link

bunnyshell bot commented May 14, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@dnrce dnrce changed the title fix(ui): Fix light/dark theme selection label fix(ui): Improve light/dark theme selector label May 14, 2025
@dnrce dnrce marked this pull request as ready for review May 14, 2025 02:58
@dnrce dnrce requested a review from a team as a code owner May 14, 2025 02:58
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@linghaoSu linghaoSu added the ready-for-review An approver should give a final review and merge the PR label May 26, 2025
@github-project-automation github-project-automation bot moved this to Ready for final review in Argo CD Review May 26, 2025
Copy link
Member

@reggie-k reggie-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reggie-k reggie-k merged commit 8fde8d0 into argoproj:master Jun 9, 2025
32 checks passed
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review An approver should give a final review and merge the PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants