Skip to content

Conversation

@hanxiaop
Copy link
Contributor

Currently, the application tree response is missing the version in the ParentRef. This is inconsistent with other usages of the same ResourceRef structure and also inconsistent with the appset tree , which includes the version:

parentRefs := []v1alpha1.ResourceRef{
{Group: gvk.Group, Version: gvk.Version, Kind: gvk.Kind, Name: a.Name, Namespace: a.Namespace, UID: string(a.UID)},
}

Adding this would be helpful for directly comparing the ParentRef with the resourceRef.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@hanxiaop hanxiaop requested a review from a team as a code owner May 12, 2025 02:43
@bunnyshell
Copy link

bunnyshell bot commented May 12, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@hanxiaop hanxiaop force-pushed the parentref-missing-version branch from fb6bac2 to 826b098 Compare May 12, 2025 02:46
@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@f4e2c6e). Learn more about missing BASE report.
⚠️ Report is 465 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #22927   +/-   ##
=========================================
  Coverage          ?   59.94%           
=========================================
  Files             ?      344           
  Lines             ?    57787           
  Branches          ?        0           
=========================================
  Hits              ?    34638           
  Misses            ?    20380           
  Partials          ?     2769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdsoumya gdsoumya merged commit 299286d into argoproj:master May 12, 2025
27 checks passed
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants