Skip to content

Conversation

@gekart
Copy link
Contributor

@gekart gekart commented May 11, 2025

The link pointed to argocd-cm.yaml directly, leading to a download of that file. Here we are pointing to argocd-cm.yaml.md to display the corresponding sample documentation.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@gekart gekart requested review from a team as code owners May 11, 2025 12:56
@bunnyshell
Copy link

bunnyshell bot commented May 11, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@gekart gekart changed the title doc: Fixed link to argocd-cm.yaml [minor] docs: Fixed link to argocd-cm.yaml [minor] May 11, 2025

Argo CD can display a badge with health and sync status for any application. The feature is disabled by default because badge image is available to any user without authentication.
The feature can be enabled using `statusbadge.enabled` key of `argocd-cm` ConfigMap (see [argocd-cm.yaml](../operator-manual/argocd-cm.yaml)).
The feature can be enabled using `statusbadge.enabled` key of `argocd-cm` ConfigMap (see [argocd-cm.yaml](../operator-manual/argocd-cm.yaml.md)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path needs to be ../operator-manual/argocd-cm-yaml.md

@gekart gekart force-pushed the fix-status-badge branch from 7293e4f to 3be35de Compare May 11, 2025 15:53
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the DCO check?

crenshaw-dev and others added 2 commits May 12, 2025 15:51
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Grischa Ekart <[email protected]>
@gekart gekart force-pushed the fix-status-badge branch from c240aee to 6f28798 Compare May 12, 2025 13:52
@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.00%. Comparing base (e28f609) to head (6f28798).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22923      +/-   ##
==========================================
- Coverage   60.04%   60.00%   -0.04%     
==========================================
  Files         344      344              
  Lines       57781    57787       +6     
==========================================
- Hits        34695    34676      -19     
- Misses      20331    20342      +11     
- Partials     2755     2769      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@todaywasawesome todaywasawesome enabled auto-merge (squash) May 13, 2025 14:51
@todaywasawesome todaywasawesome merged commit 44294a5 into argoproj:master May 13, 2025
22 checks passed
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Grischa Ekart <[email protected]>
Signed-off-by: Dan Garfield <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
Signed-off-by: Kanika Rana <[email protected]>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Grischa Ekart <[email protected]>
Signed-off-by: Dan Garfield <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
Signed-off-by: Oliver Gondža <[email protected]>
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Grischa Ekart <[email protected]>
Signed-off-by: Dan Garfield <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Grischa Ekart <[email protected]>
Signed-off-by: Dan Garfield <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Grischa Ekart <[email protected]>
Signed-off-by: Dan Garfield <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
Signed-off-by: dsuhinin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants