-
Notifications
You must be signed in to change notification settings - Fork 6.5k
docs: Fixed link to argocd-cm.yaml [minor] #22923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
docs/user-guide/status-badge.md
Outdated
|
|
||
| Argo CD can display a badge with health and sync status for any application. The feature is disabled by default because badge image is available to any user without authentication. | ||
| The feature can be enabled using `statusbadge.enabled` key of `argocd-cm` ConfigMap (see [argocd-cm.yaml](../operator-manual/argocd-cm.yaml)). | ||
| The feature can be enabled using `statusbadge.enabled` key of `argocd-cm` ConfigMap (see [argocd-cm.yaml](../operator-manual/argocd-cm.yaml.md)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path needs to be ../operator-manual/argocd-cm-yaml.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you fix the DCO check?
Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Grischa Ekart <[email protected]>
Signed-off-by: Grischa Ekart <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22923 +/- ##
==========================================
- Coverage 60.04% 60.00% -0.04%
==========================================
Files 344 344
Lines 57781 57787 +6
==========================================
- Hits 34695 34676 -19
- Misses 20331 20342 +11
- Partials 2755 2769 +14 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Dan Garfield <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Grischa Ekart <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Kanika Rana <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Grischa Ekart <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Oliver Gondža <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Grischa Ekart <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: Dan Garfield <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Grischa Ekart <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: Dan Garfield <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Grischa Ekart <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: dsuhinin <[email protected]>
The link pointed to argocd-cm.yaml directly, leading to a download of that file. Here we are pointing to argocd-cm.yaml.md to display the corresponding sample documentation.
Checklist: