Skip to content

docs: Correct project role RBAC wording in projects.md [Minor] #22922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

docs: Correct project role RBAC wording in projects.md [Minor] #22922

merged 1 commit into from
May 12, 2025

Conversation

@gekart
Copy link
Contributor

@gekart gekart commented May 11, 2025 •
edited
Loading

Bug in docs: The "project Roles" is a project named Roles and "allows" in singular stresses this. The correct wording is "project roles allow".

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@gekart
Correct project role RBAC wording in projects.md
d1fc813 
The "project Roles" is a project named Roles and "allows" in singular stresses this. The correct wording is "project roles allow".

Signed-off-by: Grischa Ekart <[email protected]>
@gekart gekart requested review from a team as code owners May 11, 2025 09:40
@bunnyshell
Copy link

bunnyshell bot commented May 11, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@gekart gekart changed the title [DOC] Correct project role RBAC wording in projects.md [Minor] docs Correct project role RBAC wording in projects.md [Minor] May 11, 2025
@gekart gekart changed the title docs Correct project role RBAC wording in projects.md [Minor] docs: Correct project role RBAC wording in projects.md [Minor] May 11, 2025
@reggie-k reggie-k merged commit 0c20652 into argoproj:master May 12, 2025
25 checks passed
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
@gekart @ranakan19
docs: Correct project role RBAC wording in projects.md [Minor] (argop…
fab5525 
…roj#22922)

Signed-off-by: Grischa Ekart <[email protected]>
Signed-off-by: Kanika Rana <[email protected]>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
@gekart @olivergondza
docs: Correct project role RBAC wording in projects.md [Minor] (argop…
0c325ea 
…roj#22922)

Signed-off-by: Grischa Ekart <[email protected]>
Signed-off-by: Oliver Gondža <[email protected]>
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
@gekart @tylerrosnett
docs: Correct project role RBAC wording in projects.md [Minor] (argop…
fac09bb 
…roj#22922)

Signed-off-by: Grischa Ekart <[email protected]>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@gekart @chansuke
docs: Correct project role RBAC wording in projects.md [Minor] (argop…
2b78261 
…roj#22922)

Signed-off-by: Grischa Ekart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reggie-k reggie-k reggie-k approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gekart @reggie-k