Skip to content

Conversation

@pjiang-dev
Copy link
Contributor

cherry-pick of db9c82a

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@pjiang-dev pjiang-dev requested a review from a team as a code owner April 28, 2025 20:21
@crenshaw-dev crenshaw-dev merged commit b163de0 into argoproj:release-2.14 Apr 28, 2025
17 of 19 checks passed
@codecov
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.27%. Comparing base (4826fb0) to head (9f62f76).
⚠️ Report is 32 commits behind head on release-2.14.

Files with missing lines Patch % Lines
util/helm/client.go 66.66% 2 Missing ⚠️
reposerver/repository/repository.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.14   #22816      +/-   ##
================================================
- Coverage         55.30%   55.27%   -0.04%     
================================================
  Files               339      339              
  Lines             57341    57345       +4     
================================================
- Hits              31715    31699      -16     
- Misses            22938    22950      +12     
- Partials           2688     2696       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants