Skip to content

Conversation

@imwithye
Copy link
Contributor

@imwithye imwithye commented Apr 24, 2025

When multiple system-level extensions are used, refreshing the second extension page redirects to /applications. This happens because extensionsLoaded is set to true after the first extension is registered, causing the second extension’s route to be missed.

This PR removes the extensionsLoaded flag and the fallback redirect, allowing the second extension to register its route correctly.

Side effect: 404 errors will now show a blank page instead of redirecting to /applications.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Yiwei Gong <[email protected]>
@imwithye imwithye requested a review from a team as a code owner April 24, 2025 07:36
@bunnyshell
Copy link

bunnyshell bot commented Apr 24, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Signed-off-by: Yiwei Gong <[email protected]>
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ishitasequeira ishitasequeira changed the title fix: resolve refresh page issue with multi system extensions fix(ui): resolve refresh page issue with multi system extensions Apr 27, 2025
@ishitasequeira ishitasequeira merged commit 814a24e into argoproj:master Apr 28, 2025
23 checks passed
Hapshanko pushed a commit to Hapshanko/argo-cd that referenced this pull request Apr 29, 2025
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
…oproj#22775)

Signed-off-by: Yiwei Gong <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>
Signed-off-by: Kanika Rana <[email protected]>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
…oproj#22775)

Signed-off-by: Yiwei Gong <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>
Signed-off-by: Oliver Gondža <[email protected]>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@avivpxi
Copy link

avivpxi commented Jun 8, 2025

when is this set to release? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants