-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(ui): resolve refresh page issue with multi system extensions #22775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ishitasequeira
merged 3 commits into
argoproj:master
from
imwithye:fix-system-extension
Apr 28, 2025
Merged
fix(ui): resolve refresh page issue with multi system extensions #22775
ishitasequeira
merged 3 commits into
argoproj:master
from
imwithye:fix-system-extension
Apr 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yiwei Gong <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Yiwei Gong <[email protected]>
nitishfy
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
wanghong230
approved these changes
Apr 24, 2025
andrii-korotkov
approved these changes
Apr 27, 2025
ishitasequeira
approved these changes
Apr 27, 2025
Hapshanko
pushed a commit
to Hapshanko/argo-cd
that referenced
this pull request
Apr 29, 2025
…oproj#22775) Signed-off-by: Yiwei Gong <[email protected]> Co-authored-by: Ishita Sequeira <[email protected]> Signed-off-by: Hapshanko <[email protected]>
ranakan19
pushed a commit
to ranakan19/argo-cd
that referenced
this pull request
May 20, 2025
…oproj#22775) Signed-off-by: Yiwei Gong <[email protected]> Co-authored-by: Ishita Sequeira <[email protected]> Signed-off-by: Kanika Rana <[email protected]>
olivergondza
pushed a commit
to olivergondza/argo-cd
that referenced
this pull request
May 20, 2025
…oproj#22775) Signed-off-by: Yiwei Gong <[email protected]> Co-authored-by: Ishita Sequeira <[email protected]> Signed-off-by: Oliver Gondža <[email protected]>
chansuke
pushed a commit
to chansuke/argo-cd
that referenced
this pull request
Jun 4, 2025
…oproj#22775) Signed-off-by: Yiwei Gong <[email protected]> Co-authored-by: Ishita Sequeira <[email protected]>
|
when is this set to release? 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple system-level extensions are used, refreshing the second extension page redirects to /applications. This happens because
extensionsLoadedis set to true after the first extension is registered, causing the second extension’s route to be missed.This PR removes the
extensionsLoadedflag and the fallback redirect, allowing the second extension to register its route correctly.Side effect: 404 errors will now show a blank page instead of redirecting to /applications.
Checklist: