Skip to content

docs: Update sync-waves.md to include more details about phases and waves #22768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 28, 2025
Merged

docs: Update sync-waves.md to include more details about phases and waves #22768

merged 13 commits into from
Apr 28, 2025

Conversation

@revitalbarletz
Copy link
Contributor

@revitalbarletz revitalbarletz commented Apr 23, 2025 •
edited
Loading

Consolidated content into sync-waves.md by including both phases and waves, and removed resource_hooks.md since all relevant information belongs in a single document.
Fixes issue #11264

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@revitalbarletz
Update sync-waves.md
22ce6f3 
Signed-off-by: Revital Barletz <[email protected]>
@revitalbarletz revitalbarletz requested review from a team as code owners April 23, 2025 12:51
@bunnyshell
Copy link

bunnyshell bot commented Apr 23, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@revitalbarletz revitalbarletz changed the title Update sync-waves.md docs: Update sync-waves.mdt Apr 23, 2025
@revitalbarletz revitalbarletz changed the title docs: Update sync-waves.mdt docs: Update sync-waves.md to include more details about phases and waves Apr 23, 2025
@revitalbarletz
Update sync-waves.md
bd256f5 
Signed-off-by: Revital Barletz <[email protected]>
@revitalbarletz
Add files via upload
b30c3b3 
Signed-off-by: Revital Barletz <[email protected]>
@revitalbarletz
Copy link
Contributor Author

revitalbarletz commented Apr 23, 2025

@kostis-codefresh What do you think?

todaywasawesome
todaywasawesome approved these changes Apr 24, 2025
View reviewed changes
todaywasawesome
todaywasawesome requested changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@revitalbarletz can you review and approve my suggestions?

revitalbarletz and others added 3 commits April 27, 2025 15:34
@revitalbarletz @todaywasawesome
Update docs/user-guide/sync-waves.md
d43a27f 
Co-authored-by: Dan Garfield <[email protected]>
Signed-off-by: Revital Barletz <[email protected]>
@revitalbarletz @todaywasawesome
Update docs/user-guide/sync-waves.md
dc43647 
Co-authored-by: Dan Garfield <[email protected]>
Signed-off-by: Revital Barletz <[email protected]>
@revitalbarletz @todaywasawesome
Update docs/user-guide/sync-waves.md
e844c7b 
Co-authored-by: Dan Garfield <[email protected]>
Signed-off-by: Revital Barletz <[email protected]>
@revitalbarletz
Copy link
Contributor Author

revitalbarletz commented Apr 27, 2025

Thank you @todaywasawesome for the comments and for the fixes.

@todaywasawesome todaywasawesome merged commit a7dce39 into argoproj:master Apr 28, 2025
23 checks passed
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
@revitalbarletz @todaywasawesome @ranakan19
docs: Update sync-waves.md to include more details about phases and w…
edf2236 
…aves (argoproj#22768)

Signed-off-by: Revital Barletz <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
Signed-off-by: Kanika Rana <[email protected]>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
@revitalbarletz @todaywasawesome @olivergondza
docs: Update sync-waves.md to include more details about phases and w…
76de9f9 
…aves (argoproj#22768)

Signed-off-by: Revital Barletz <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
Signed-off-by: Oliver Gondža <[email protected]>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@revitalbarletz @todaywasawesome @chansuke
docs: Update sync-waves.md to include more details about phases and w…
804d041 
…aves (argoproj#22768)

Signed-off-by: Revital Barletz <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
@revitalbarletz revitalbarletz mentioned this pull request Aug 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@todaywasawesome todaywasawesome todaywasawesome approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@revitalbarletz @todaywasawesome