Skip to content

Conversation

@blakepettersson
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@blakepettersson blakepettersson requested a review from a team as a code owner April 22, 2025 08:14
@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.22%. Comparing base (4826fb0) to head (131fbdc).
⚠️ Report is 32 commits behind head on release-2.14.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.14   #22746      +/-   ##
================================================
- Coverage         55.30%   55.22%   -0.09%     
================================================
  Files               339      339              
  Lines             57341    57358      +17     
================================================
- Hits              31715    31674      -41     
- Misses            22938    22982      +44     
- Partials           2688     2702      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@todaywasawesome todaywasawesome changed the title fix: do not normalize resource tracking on live crds (#22722) fix: do not normalize resource tracking on live crds (#22722) - cherrypick 2.14 Apr 22, 2025
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs make codegen

@blakepettersson blakepettersson added the ready-for-review An approver should give a final review and merge the PR label Apr 28, 2025
@github-project-automation github-project-automation bot moved this to Ready for final review in Argo CD Review Apr 28, 2025
@agaudreault agaudreault merged commit fe93963 into argoproj:release-2.14 May 7, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review An approver should give a final review and merge the PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants