Skip to content

docs: add a precise description on helm chart prerelease version comparison. Fixes #21818 #22724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2025
Merged

docs: add a precise description on helm chart prerelease version comparison. Fixes #21818 #22724

merged 2 commits into from
Apr 19, 2025

Conversation

@sspreitzer
Copy link
Contributor

@sspreitzer sspreitzer commented Apr 18, 2025

This PR adds a precise documentation about Helm Chart prerelease comparison constraints and how to use them.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@sspreitzer sspreitzer requested review from a team as code owners April 18, 2025 20:30
@bunnyshell
Copy link

bunnyshell bot commented Apr 18, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@sspreitzer sspreitzer force-pushed the feat/docs-helm-chart-prerelease-versions branch from b1ad68f to 34d6df9 Compare April 18, 2025 20:38
blakepettersson
blakepettersson approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

blakepettersson
blakepettersson reviewed Apr 18, 2025
View reviewed changes
@sspreitzer sspreitzer force-pushed the feat/docs-helm-chart-prerelease-versions branch from 34d6df9 to d777875 Compare April 19, 2025 08:21
nitishfy
nitishfy approved these changes Apr 19, 2025
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crenshaw-dev
crenshaw-dev reviewed Apr 19, 2025
View reviewed changes
@blakepettersson blakepettersson merged commit 4b6566a into argoproj:master Apr 19, 2025
23 checks passed
@sspreitzer sspreitzer deleted the feat/docs-helm-chart-prerelease-versions branch April 19, 2025 19:24
Hapshanko pushed a commit to Hapshanko/argo-cd that referenced this pull request Apr 29, 2025
@sspreitzer @crenshaw-dev @Hapshanko
docs: add a precise description on helm chart prerelease version comp…
840ed96 
…arison. Fixes argoproj#21818 (argoproj#22724)

Signed-off-by: Sascha Spreitzer <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Hapshanko <[email protected]>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
@sspreitzer @crenshaw-dev @olivergondza
docs: add a precise description on helm chart prerelease version comp…
1b31c2e 
…arison. Fixes argoproj#21818 (argoproj#22724)

Signed-off-by: Sascha Spreitzer <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Oliver Gondža <[email protected]>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@sspreitzer @crenshaw-dev @chansuke
docs: add a precise description on helm chart prerelease version comp…
0ca1d7b 
…arison. Fixes argoproj#21818 (argoproj#22724)

Signed-off-by: Sascha Spreitzer <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev left review comments

@blakepettersson blakepettersson blakepettersson approved these changes

@nitishfy nitishfy nitishfy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sspreitzer @crenshaw-dev @blakepettersson @nitishfy