Skip to content

Conversation

@afzal442
Copy link
Contributor

@afzal442 afzal442 commented Apr 17, 2025

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@afzal442 afzal442 requested review from a team as code owners April 17, 2025 09:38
@bunnyshell
Copy link

bunnyshell bot commented Apr 17, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the instructions that you removed were required for ARM architecture. Please update the existing mac installation docs too to reflect the installation for ARM architecture.

@afzal442
Copy link
Contributor Author

I see, we need installation for ARM architecture, not AMD.

Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing the context here. Let me reframe it this way:

The instructions that you removed are required for the installation on mac ARM architecture. The docs were written in a way to perform installation for both AMD or ARM. So if you plan to remove the redundant information, please make sure to provide necessary details for installation for both AMD and ARM architecture.

@cardoe
Copy link
Contributor

cardoe commented Apr 17, 2025

Why is this removing the Homebrew for Linux instructions too?

@nitishfy
Copy link
Member

Why is this removing the Homebrew for Linux instructions too?

@afzal442 ^^

@afzal442
Copy link
Contributor Author

I see. Sorry for the upside-down. Thanks @nitishfy @cardoe

@afzal442 afzal442 requested a review from nitishfy April 21, 2025 12:09
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why we would remove install instructions with curl. Some people prefer that over homebrew. The "M1" headline should be changed to "Apple Silicon" and maybe you want to add some heading information to share that you can install via curl or homebrew.

@afzal442
Copy link
Contributor Author

I don't see why we would remove install instructions with curl.

It's there already;

The "M1" headline should be changed to "Apple Silicon" and maybe you want to add some heading information to share that you can install via curl or homebrew.

Addressed.

Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL.

Signed-off-by: Afzal Ansari <[email protected]>
@afzal442 afzal442 requested a review from nitishfy April 23, 2025 16:47
@afzal442
Copy link
Contributor Author

Any review will be great. @nitishfy @todaywasawesome

Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@todaywasawesome todaywasawesome merged commit ba9ad75 into argoproj:master Apr 29, 2025
23 checks passed
@afzal442 afzal442 deleted the patch-1 branch April 30, 2025 07:24
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants