-
Notifications
You must be signed in to change notification settings - Fork 6.5k
docs: remove argocd installation redundant steps for Mac users #22705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Afzal Ansari <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
nitishfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the instructions that you removed were required for ARM architecture. Please update the existing mac installation docs too to reflect the installation for ARM architecture.
|
I see, we need installation for ARM architecture, not AMD. |
Signed-off-by: Afzal Ansari <[email protected]>
nitishfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
Signed-off-by: Afzal Ansari <[email protected]>
nitishfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing the context here. Let me reframe it this way:
The instructions that you removed are required for the installation on mac ARM architecture. The docs were written in a way to perform installation for both AMD or ARM. So if you plan to remove the redundant information, please make sure to provide necessary details for installation for both AMD and ARM architecture.
|
Why is this removing the Homebrew for Linux instructions too? |
@afzal442 ^^ |
Signed-off-by: Afzal Ansari <[email protected]>
Signed-off-by: Afzal Ansari <[email protected]>
todaywasawesome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why we would remove install instructions with curl. Some people prefer that over homebrew. The "M1" headline should be changed to "Apple Silicon" and maybe you want to add some heading information to share that you can install via curl or homebrew.
Signed-off-by: Afzal Ansari <[email protected]>
It's there already;
Addressed. |
nitishfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL.
Signed-off-by: Afzal Ansari <[email protected]>
|
Any review will be great. @nitishfy @todaywasawesome |
todaywasawesome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go
…roj#22705) Signed-off-by: Afzal Ansari <[email protected]> Signed-off-by: Kanika Rana <[email protected]>
…roj#22705) Signed-off-by: Afzal Ansari <[email protected]> Signed-off-by: Oliver Gondža <[email protected]>
…roj#22705) Signed-off-by: Afzal Ansari <[email protected]>
Checklist: