-
Notifications
You must be signed in to change notification settings - Fork 6.5k
docs: Style and formatting fixes in the developer guide #22677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Oliver Gondža <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
|
|
||
| CVEs in dependencies will be patched for all supported versions if the CVE is applicable and is assessed by Snyk to be | ||
| of high or critical severity. Automation generates a [new Snyk scan weekly](../snyk). | ||
| of high or critical severity. Automation generates a [new Snyk scan weekly](../../snyk). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the only significant change. The rest is cosmetics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this break the markdown? Shouldn't it be [new Snyk scan weekly](../snyk/index.md)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not, I have verified using make serve-docs that this fixes the problem.
Page with the link https://argo-cd.readthedocs.io/en/latest/developer-guide/release-process-and-cadence/
Old destination https://argo-cd.readthedocs.io/en/latest/developer-guide/snyk/ (404)
New destination https://argo-cd.readthedocs.io/en/latest/snyk/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It breaks when rendering the markdown locally using an IDE. I believe [new Snyk scan weekly](../snyk/index.md) works in both cases. Using make serve-docs and locally in the IDE.
Screen.Recording.2025-04-22.at.9.11.53.AM.mov
Where with [new Snyk scan weekly](../../snyk) it breaks the local markdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, you are correct that IntelliJ IDEA fails to render it (too). What you suggest works in both, my IDE and local rendering. Another big advantage of what you suggest (always use file name/.md suffix), is that file navigation works when MD is rendered on github.com file navigator.
Tough, the docs are full of links that does not work for the same reason (they work on argo-cd.readthedocs.io). Like the 3 following:
argo-cd/docs/developer-guide/index.md
Line 10 in 06184df
| ## Contributing to Argo CD |
I am sold, but lets do this across the board in separate PR. For this one link, I am ok to change it here.
…github Signed-off-by: Oliver Gondža <[email protected]>
Signed-off-by: Oliver Gondža <[email protected]> Signed-off-by: Hapshanko <[email protected]>
Signed-off-by: Oliver Gondža <[email protected]>
Signed-off-by: Oliver Gondža <[email protected]>
Checklist: