-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: respect delete confirmation for argocd app deletion #22657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: nitishfy <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22657 +/- ##
==========================================
- Coverage 56.04% 56.01% -0.03%
==========================================
Files 343 343
Lines 57536 57536
==========================================
- Hits 32247 32230 -17
- Misses 22643 22652 +9
- Partials 2646 2654 +8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: nitishfy <[email protected]>
9d97c71 to
ac0d7f5
Compare
rumstead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/cherry-pick release-2.14 |
Signed-off-by: nitishfy <[email protected]>
|
/cherry-pick release-2.13 |
|
Cherry-pick failed with |
…22657) (#22664) Signed-off-by: nitishfy <[email protected]> Co-authored-by: Nitish Kumar <[email protected]>
) Signed-off-by: nitishfy <[email protected]> Signed-off-by: Vasile Groza <[email protected]>
) Signed-off-by: nitishfy <[email protected]> Signed-off-by: Hapshanko <[email protected]>
Closes #22656
After
Checklist: