Skip to content

Conversation

@nitishfy
Copy link
Member

@nitishfy nitishfy commented Apr 14, 2025

Closes #22656

After

> dist/argocd app list            
NAME                               CLUSTER                         NAMESPACE  PROJECT  STATUS     HEALTH   SYNCPOLICY  CONDITIONS  REPO                                                 PATH                                                               TARGET
argocd/engineering-dev-guestbook   https://kubernetes.default.svc  guestbook  default  OutOfSync  Missing  Manual      <none>      https://github.com/argoproj/argo-cd.git              applicationset/examples/list-generator/guestbook/engineering-dev   HEAD
argocd/engineering-prod-guestbook  https://kubernetes.default.svc  guestbook  default  OutOfSync  Missing  Manual      <none>      https://github.com/argoproj/argo-cd.git              applicationset/examples/list-generator/guestbook/engineering-prod  HEAD
argocd/guestbook1                  https://kubernetes.default.svc  default    default  OutOfSync  Missing  Manual      <none>      https://github.com/argoproj/argocd-example-apps.git  guestbook                                                          
               
> dist/argocd appset list
NAME              PROJECT  SYNCPOLICY  CONDITIONS                                                                                                                                                                                                                                     REPO                                     PATH                                                           TARGET
argocd/guestbook  default  nil         [{ParametersGenerated Successfully generated parameters for all Applications 2025-04-14 10:53:11 +0530 IST True ParametersGenerated} {ResourcesUpToDate ApplicationSet up to date 2025-04-14 10:53:11 +0530 IST True ApplicationSetUpToDate}]  https://github.com/argoproj/argo-cd.git  applicationset/examples/list-generator/guestbook/{{.cluster}}  HEAD
               
> dist/argocd app delete guestbook1
Are you sure you want to delete 'guestbook1' and all its resources? [y/n] n
The command to delete 'guestbook1' was cancelled.
               
> dist/argocd app delete guestbook1
Are you sure you want to delete 'guestbook1' and all its resources? [y/n] y
application 'guestbook1' deleted
               
> dist/argocd appset delete guestbook
Are you sure you want to delete 'guestbook' and all its Applications? [y/n] n
The command to delete 'guestbook' was cancelled.
               
> dist/argocd appset delete guestbook
Are you sure you want to delete 'guestbook' and all its Applications? [y/n] y
applicationset 'guestbook' deleted

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: nitishfy <[email protected]>
@nitishfy nitishfy requested a review from a team as a code owner April 14, 2025 05:22
@bunnyshell
Copy link

bunnyshell bot commented Apr 14, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.01%. Comparing base (f6e15d2) to head (6f11040).
Report is 457 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22657      +/-   ##
==========================================
- Coverage   56.04%   56.01%   -0.03%     
==========================================
  Files         343      343              
  Lines       57536    57536              
==========================================
- Hits        32247    32230      -17     
- Misses      22643    22652       +9     
- Partials     2646     2654       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nitishfy nitishfy force-pushed the nitish/app-deletion branch from 9d97c71 to ac0d7f5 Compare April 14, 2025 13:43
@nitishfy nitishfy requested a review from rumstead April 14, 2025 13:44
Copy link
Member

@rumstead rumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rumstead rumstead merged commit e72ebb0 into argoproj:master Apr 14, 2025
27 checks passed
@nitishfy nitishfy deleted the nitish/app-deletion branch April 14, 2025 15:12
@alexmt
Copy link
Collaborator

alexmt commented Apr 14, 2025

/cherry-pick release-2.14

@alexmt
Copy link
Collaborator

alexmt commented Apr 14, 2025

/cherry-pick release-2.13

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error e72ebb0098a38a29562f1b6f1ac532818a53f6b9 into temp-cherry-pick-1b9f9c-release-2.13

alexmt pushed a commit that referenced this pull request Apr 14, 2025
vasilegroza pushed a commit to vasilegroza/argo-cd that referenced this pull request Apr 14, 2025
Hapshanko pushed a commit to Hapshanko/argo-cd that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI app deletion confirmation not respected

3 participants