Skip to content

Conversation

@heshamelsherif97
Copy link

@heshamelsherif97 heshamelsherif97 commented Apr 13, 2025

chore(deps) porting latest dependabot patches to github.com/expr-lang/expr to 2.14 release. which is already patched in master fixing CVE-2025-29786

Relevant PRs

Users relying on 2.14 for custom image builds are likely encountering issues due to CVE-2025-29786. Can we prioritize a patch release to address this vulnerability?

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@heshamelsherif97 heshamelsherif97 requested a review from a team as a code owner April 13, 2025 18:28
@codecov
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.27%. Comparing base (3b308d6) to head (d721238).
Report is 32 commits behind head on release-2.14.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.14   #22651      +/-   ##
================================================
- Coverage         55.29%   55.27%   -0.03%     
================================================
  Files               339      339              
  Lines             57341    57341              
================================================
- Hits              31705    31693      -12     
- Misses            22941    22951      +10     
- Partials           2695     2697       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heshamelsherif97 heshamelsherif97 changed the title chore(deps): Update github.com/expr-lang/expr to v1.17.2 chore(deps): Update github.com/expr-lang/expr to v1.17.0 fixing CVE-2025-29786. Apr 14, 2025
@heshamelsherif97 heshamelsherif97 changed the title chore(deps): Update github.com/expr-lang/expr to v1.17.0 fixing CVE-2025-29786. chore(deps): Update github.com/expr-lang/expr to v1.17.0 fixing CVE-2025-29786 Apr 14, 2025
@heshamelsherif97 heshamelsherif97 force-pushed the fix-CVE-2025-29786 branch 2 times, most recently from 11a92d5 to ab4f637 Compare April 14, 2025 21:22
@heshamelsherif97 heshamelsherif97 marked this pull request as draft April 14, 2025 21:24
@heshamelsherif97 heshamelsherif97 marked this pull request as ready for review April 14, 2025 21:29
@crenshaw-dev crenshaw-dev merged commit 4826fb0 into argoproj:release-2.14 Apr 14, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants