Skip to content

Conversation

@gregbarasch
Copy link
Contributor

@gregbarasch gregbarasch commented Apr 8, 2025

Fixes #22504
This adds simple health checks for Contour HTTPProxy objects

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@bunnyshell
Copy link

bunnyshell bot commented Apr 8, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.85%. Comparing base (362dc66) to head (f94f073).
⚠️ Report is 542 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #22596   +/-   ##
=======================================
  Coverage   59.84%   59.85%           
=======================================
  Files         344      344           
  Lines       57715    57715           
=======================================
+ Hits        34541    34546    +5     
- Misses      20402    20405    +3     
+ Partials     2772     2764    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

else
hs.status = "Degraded"
end
hs.message = obj.status.description

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the message used for anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah -- this is what is returned to ArgoCD, and it links back with:

type HealthStatus struct {
	Status  HealthStatusCode `json:"status,omitempty"`
	Message string           `json:"message,omitempty"`
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davinci26
Copy link

Fixes #22504

@crenshaw-dev crenshaw-dev added the component:health-check Issue related to built-in Health Check customizations label Apr 30, 2025
@gregbarasch gregbarasch changed the title This is a pass at adding Contour HTTPProxy health check support feat: Contour HTTPProxy health check support May 5, 2025
@gregbarasch gregbarasch force-pushed the contour-httpproxy-healthcheck-lua branch from 671a7b9 to 9eb0f75 Compare May 5, 2025 23:00
@gregbarasch gregbarasch changed the title feat: Contour HTTPProxy health check support feat: Contour HTTPProxy health check support for issue # 22504 May 5, 2025
@gregbarasch
Copy link
Contributor Author

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

/bns:start

@gregbarasch gregbarasch marked this pull request as ready for review May 6, 2025 00:01
@gregbarasch gregbarasch requested a review from a team as a code owner May 6, 2025 00:01
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A future iteration could pull the error messages and add them to the health message, but this at least gets the party started. :-) Thanks!

@crenshaw-dev crenshaw-dev merged commit ce4b7a2 into argoproj:master May 21, 2025
27 checks passed
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 24, 2025
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:health-check Issue related to built-in Health Check customizations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Contour/HTTPProxy resource health

4 participants