Skip to content

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Apr 2, 2025

Description

  • sort fields alphabetically
  • move SA5011 exclusion to staticcheck linter settings
  • log a warning if an exclusion rule is unused.

@bunnyshell
Copy link

bunnyshell bot commented Apr 2, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@mmorel-35 mmorel-35 force-pushed the cleanup-golangci-lint branch 2 times, most recently from 46de905 to fccd4c7 Compare April 2, 2025 05:55
@mmorel-35 mmorel-35 force-pushed the cleanup-golangci-lint branch from fccd4c7 to 9f88ddc Compare April 2, 2025 06:33
@mmorel-35 mmorel-35 marked this pull request as ready for review April 2, 2025 06:34
@mmorel-35 mmorel-35 requested a review from a team as a code owner April 2, 2025 06:34
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.01%. Comparing base (ffe4225) to head (9f88ddc).
Report is 460 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22544      +/-   ##
==========================================
- Coverage   56.03%   56.01%   -0.03%     
==========================================
  Files         343      343              
  Lines       57568    57527      -41     
==========================================
- Hits        32258    32221      -37     
- Misses      22659    22660       +1     
+ Partials     2651     2646       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rumstead rumstead merged commit 5b0d765 into argoproj:master Apr 2, 2025
27 checks passed
@mmorel-35 mmorel-35 deleted the cleanup-golangci-lint branch April 2, 2025 15:53
Hapshanko pushed a commit to Hapshanko/argo-cd that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants