chore(ci): upgrade golangci-lint to v2

[crenshaw-dev]

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 160 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@f8b5b0b). Learn more about missing BASE report.
Report is 453 commits behind head on master.

Files with missing lines	Patch %	Lines
cmd/argocd/commands/app.go	18.18%	27 Missing ⚠️
applicationset/utils/applicationset_lister.go	11.11%	8 Missing ⚠️
pkg/apis/application/v1alpha1/types.go	61.90%	6 Missing and 2 partials ⚠️
util/clusterauth/clusterauth.go	0.00%	8 Missing ⚠️
util/gpg/gpg.go	12.50%	7 Missing ⚠️
cmd/argocd/commands/cert.go	0.00%	6 Missing ⚠️
server/server.go	57.14%	3 Missing and 3 partials ⚠️
cmd/argocd/commands/applicationset.go	0.00%	5 Missing ⚠️
util/argo/audit_logger.go	73.68%	5 Missing ⚠️
...cationset/controllers/applicationset_controller.go	85.00%	2 Missing and 1 partial ⚠️
... and 43 more

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #22484   +/-   ##
=========================================
  Coverage          ?   55.97%           
=========================================
  Files             ?      343           
  Lines             ?    57425           
  Branches          ?        0           
=========================================
  Hits              ?    32141           
  Misses            ?    22643           
  Partials          ?     2641           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[agaudreault]

LGTM

[leoluz]

I looks a bit more picky but LGTM

[crenshaw-dev]

@leoluz yeah I have mixed feelings about linters... so far our relatively-strict settings haven't been super annoying. I've been pleasantly surprised. :-)