feat: add server side apps pagination(#14947) #22444

muma378 · 2025-03-22T07:29:55Z

KEP: #17222

Closes #14947

Checklist:

bunnyshell · 2025-03-22T07:29:59Z

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

🚀 /bns:deploy to deploy the environment

codecov · 2025-03-22T17:24:34Z

Codecov Report

Attention: Patch coverage is 8.20312% with 235 lines in your changes missing coverage. Please review.

Project coverage is 59.97%. Comparing base (09b5cbd) to head (cb7d492).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
util/argo/pagination.go	0.00%	218 Missing ⚠️
cmd/argocd/commands/app.go	35.71%	9 Missing ⚠️
pkg/apis/application/v1alpha1/types.go	0.00%	5 Missing ⚠️
server/application/application.go	88.88%	2 Missing ⚠️
cmd/argocd/commands/applicationset.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #22444      +/-   ##
==========================================
- Coverage   60.22%   59.97%   -0.25%     
==========================================
  Files         346      347       +1     
  Lines       59197    59397     +200     
==========================================
- Hits        35653    35626      -27     
- Misses      20686    20909     +223     
- Partials     2858     2862       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

muma378 · 2025-03-23T03:10:54Z

PTAL @alexmt

server/application/application.go

server/application/application.proto

server/application/application.go

linghaoSu

LGTM

PS: If you're not interested in making modifications in the frontend/CLI, I'm happy to take this on.

muma378 · 2025-03-28T10:27:38Z

LGTM

PS: If you're not interested in making modifications in the frontend/CLI, I'm happy to take this on.

Great! I know nothing about UI stack, please feel free to do it.

thandleman-r7 · 2025-04-16T03:11:37Z

@linghaoSu Any idea on when you might get around to the frontend implementation? Eagerly awaiting this feature :)

DanielYWoo · 2025-05-13T07:22:59Z

Love, it, really appreciate if you can release it, our ArgoCD home page has been stuck there for months because the browser cannot handle 5000+ apps in a single response.

agaudreault · 2025-05-14T17:02:28Z

pkg/apis/application/v1alpha1/types.go

 	metav1.ListMeta `json:"metadata" protobuf:"bytes,1,opt,name=metadata"`
-	Items           []Application `json:"items" protobuf:"bytes,2,rep,name=items"`
+	Items           []Application        `json:"items" protobuf:"bytes,2,rep,name=items"`
+	Stats           ApplicationListStats `json:"stats,omitempty" protobuf:"bytes,3,opt,name=stats"`


The list stats should be part of an ApplicationListResponse object specific to the server/application/application.proto.

Sure, that sounds more reasonable, but it might be a problem that a breaking change was introduced. Maybe we should add a new method instead of modifying the return type of the existing one?

agaudreault · 2025-05-14T17:06:47Z

server/application/application.proto

+	// the application name to start from (app with min name is included in response)
+	optional string minName = 9;
+	// the application name to end at (app with max name is included in response)
+	optional string maxName = 10;
+	// the repos filter, ignore if the field repo was defined
+	repeated string repos = 11;
+	// the clusters filter
+	repeated string clusters = 12;
+	// the namespaces filter
+	repeated string namespaces = 13;
+	// the auth sync filter
+	optional bool autoSyncEnabled = 14;
+	// the sync status filter
+	repeated string syncStatuses = 15;
+	// the health status filter
+	repeated string healthStatuses = 16;
+	// search
+	optional string search = 17;
+  	// offset
+	optional int64 offset = 18;
+	// limit
+	optional int64 limit = 19;
+	// sort by enum=name;created-at;synchronized
+	optional ApplicationSortBy sortBy = 20;


These should be wrapped in a ListOptions object. Since some fields are duplicated, the old fields should probably be flagged as deprecated.

agaudreault · 2025-05-14T17:10:41Z

server/application/application.go

+	return q.Repos
+}
+
+func buildFilter(q application.ApplicationQuery) argo.Filter {


Move to its own utils package.

agaudreault · 2025-05-14T17:16:24Z

server/application/application.go

-	for _, project := range getProjectsFromApplicationQuery(*q) {
-		projects[project] = true
-	}
+	filter := buildFilter(*q)


The watch/get code is different that the list.
Perhaps they should 1) Not use the same ApplicationQuery object and 2) not have any of the listing logic.

Sorry, I’m not quite sure I understand. Could you clarify the difference between watch and get in this context? From what I see, all the filters seem applicable to the watch logic as well, so that the UI only receives events related to the applications it’s interested in.

@agaudreault can you help us review this change? thanks

@muma378 can we find another one to review this PR?

Whisper40 · 2025-07-04T08:08:39Z

Hi @agaudreault, can you tell us when this PR will be released ?

Signed-off-by: yang.xiao <[email protected]>

thandleman-r7 · 2025-08-07T21:59:54Z

@crenshaw-dev Wondering if we can get some attention here. I think many of us are eagerly awaiting this feature to be implemented. Thanks!

thandleman-r7 · 2025-09-08T20:48:45Z

For folks awaiting this feature, I have reached out in one of the CNCF Slack channels for ArgoCD to try and get some attention

thandleman-r7 · 2025-09-09T14:56:21Z

Unfortunately development is not ongoing. This was the response I received:

It has been discussed internally with the original contributor. There is currently no ongoing work being done in the PR.
Since this is a complex feature, it will most likely require multiple PRs, API changes and a high involvement with the community on the steps to implement the proposal.

muma378 requested a review from a team as a code owner March 22, 2025 07:29

muma378 force-pushed the feat/application-pagination branch 3 times, most recently from 3a39083 to 2bf3a0c Compare March 22, 2025 16:43

muma378 requested a review from a team as a code owner March 22, 2025 16:43

muma378 force-pushed the feat/application-pagination branch from 2bf3a0c to 58e7d03 Compare March 23, 2025 02:57

muma378 changed the title ~~feat: add server side apps pagination(#17222)~~ feat: add server side apps pagination(#14947) Mar 23, 2025

muma378 force-pushed the feat/application-pagination branch from 58e7d03 to 6306337 Compare March 23, 2025 03:09

muma378 force-pushed the feat/application-pagination branch from 6306337 to 3b80d3b Compare March 23, 2025 03:24

reggie-k added this to the v3.1 milestone Mar 23, 2025

linghaoSu reviewed Mar 24, 2025

View reviewed changes

server/application/application.go Outdated Show resolved Hide resolved

server/application/application.go Outdated Show resolved Hide resolved

linghaoSu reviewed Mar 24, 2025

View reviewed changes

server/application/application.proto Outdated Show resolved Hide resolved

muma378 force-pushed the feat/application-pagination branch 2 times, most recently from c43997a to 44322fa Compare March 27, 2025 05:49

crenshaw-dev reviewed Mar 27, 2025

View reviewed changes

server/application/application.go Outdated Show resolved Hide resolved

muma378 force-pushed the feat/application-pagination branch 2 times, most recently from 9deaaaa to 228710c Compare March 28, 2025 05:40

muma378 requested review from crenshaw-dev and linghaoSu March 28, 2025 07:11

linghaoSu approved these changes Mar 28, 2025

View reviewed changes

muma378 force-pushed the feat/application-pagination branch from 228710c to 9ebb492 Compare April 1, 2025 23:51

muma378 force-pushed the feat/application-pagination branch 2 times, most recently from 68bfe23 to 786d15e Compare April 20, 2025 16:30

muma378 mentioned this pull request May 8, 2025

REQUEST: New membership for @muma378 argoproj/argoproj#369

Open

6 tasks

muma378 force-pushed the feat/application-pagination branch from 786d15e to e04eac5 Compare May 9, 2025 05:05

agaudreault requested changes May 14, 2025

View reviewed changes

DanielYWoo mentioned this pull request May 27, 2025

Server-side pagination to make ArgoCD UI a rocket #14947

Open

agaudreault modified the milestones: v3.1, v3.2 Jun 12, 2025

muma378 force-pushed the feat/application-pagination branch 2 times, most recently from cea5e12 to 9516f5f Compare July 6, 2025 07:54

feat: add server side apps pagination

4dfda5f

Signed-off-by: yang.xiao <[email protected]>

muma378 force-pushed the feat/application-pagination branch from 9516f5f to cb7d492 Compare July 6, 2025 23:39

feat: move build filter to own package

8bb03f0

Signed-off-by: yang.xiao <[email protected]>

muma378 force-pushed the feat/application-pagination branch from cb7d492 to 8bb03f0 Compare July 8, 2025 04:33

feat: add server side apps pagination(#14947) #22444

Are you sure you want to change the base?

feat: add server side apps pagination(#14947) #22444

Uh oh!

Conversation

muma378 commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bunnyshell bot commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment undeployed from Bunnyshell

Uh oh!

codecov bot commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

muma378 commented Mar 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

linghaoSu left a comment

Choose a reason for hiding this comment

Uh oh!

muma378 commented Mar 28, 2025

Uh oh!

thandleman-r7 commented Apr 16, 2025

Uh oh!

DanielYWoo commented May 13, 2025

Uh oh!

agaudreault May 14, 2025

Choose a reason for hiding this comment

Uh oh!

muma378 May 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agaudreault May 14, 2025

Choose a reason for hiding this comment

Uh oh!

agaudreault May 14, 2025

Choose a reason for hiding this comment

Uh oh!

agaudreault May 14, 2025

Choose a reason for hiding this comment

Uh oh!

muma378 May 25, 2025

Choose a reason for hiding this comment

Uh oh!

DanielYWoo Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

DanielYWoo Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

Whisper40 commented Jul 4, 2025

Uh oh!

thandleman-r7 commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thandleman-r7 commented Sep 8, 2025

Uh oh!

thandleman-r7 commented Sep 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

muma378 commented Mar 22, 2025 •

edited

Loading

bunnyshell bot commented Mar 22, 2025 •

edited

Loading

codecov bot commented Mar 22, 2025 •

edited

Loading

muma378 May 25, 2025 •

edited

Loading

thandleman-r7 commented Aug 7, 2025 •

edited

Loading