-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: update field name from syncPolicy.automated.enable to enabled #22440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update field name from syncPolicy.automated.enable to enabled #22440
Conversation
❌ Preview Environment undeployed from BunnyshellAvailable commands (reply to this comment):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are failing. Can you make sure to pass the required checks?
update field name spec.syncPolicy.automated.enable to follow naming standard Signed-off-by: Anand Kumar Singh <[email protected]>
Signed-off-by: Anand Kumar Singh <[email protected]>
57c9377 to
22b60fe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22440 +/- ##
==========================================
+ Coverage 55.88% 55.90% +0.02%
==========================================
Files 343 343
Lines 57333 57333
==========================================
+ Hits 32038 32051 +13
+ Misses 22650 22640 -10
+ Partials 2645 2642 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rgoproj#22440) Signed-off-by: Anand Kumar Singh <[email protected]> Signed-off-by: Hapshanko <[email protected]>
Update field name spec.syncPolicy.automated.enable to follow naming standard as stated in the attached issue, it will make the naming more streamlined with previously created similar fields.
fixes: #22439
Checklist: