Skip to content

Conversation

@hua-ri
Copy link
Contributor

@hua-ri hua-ri commented Mar 21, 2025

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@hua-ri hua-ri requested a review from a team as a code owner March 21, 2025 17:27
@bunnyshell
Copy link

bunnyshell bot commented Mar 21, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.95%. Comparing base (a916289) to head (fd29f71).
Report is 449 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22434      +/-   ##
==========================================
+ Coverage   55.92%   55.95%   +0.03%     
==========================================
  Files         343      343              
  Lines       57332    57332              
==========================================
+ Hits        32062    32082      +20     
+ Misses      22628    22615      -13     
+ Partials     2642     2635       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hua-ri hua-ri requested a review from MIcQo March 22, 2025 01:50
@blakepettersson blakepettersson added the ready-for-review An approver should give a final review and merge the PR label Mar 23, 2025
@github-project-automation github-project-automation bot moved this to Ready for final review in Argo CD Review Mar 23, 2025
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition. Thanks!

@rumstead rumstead merged commit d171179 into argoproj:master Mar 24, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Ready for final review to Done in Argo CD Review Mar 24, 2025
Hapshanko pushed a commit to Hapshanko/argo-cd that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review An approver should give a final review and merge the PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants