Skip to content

fix(ui): use correct monaco editor config for correct behavior #22421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

fix(ui): use correct monaco editor config for correct behavior #22421

merged 1 commit into from
Mar 21, 2025

Conversation

@linghaoSu
Copy link
Member

@linghaoSu linghaoSu commented Mar 20, 2025 •
edited
Loading

Fixes #22422

Before

monaco-editor-scroll-before.mp4

After

monaco-editor-scroll-after.mp4

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell
Copy link

bunnyshell bot commented Mar 20, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@linghaoSu linghaoSu force-pushed the fix/manoco-editor-scroll branch from 4ed0a89 to e556da5 Compare March 20, 2025 08:08
@linghaoSu linghaoSu force-pushed the fix/manoco-editor-scroll branch from e556da5 to cc5f171 Compare March 20, 2025 08:09
@linghaoSu linghaoSu marked this pull request as ready for review March 20, 2025 08:24
@linghaoSu linghaoSu requested a review from a team as a code owner March 20, 2025 08:24
@agaudreault agaudreault merged commit 401e835 into argoproj:master Mar 21, 2025
26 of 28 checks passed
PaulSonOfLars pushed a commit to PaulSonOfLars/argo-cd that referenced this pull request Mar 22, 2025
@linghaoSu @PaulSonOfLars
fix(ui): use correct monaco editor config for correct behavior (argop…
40aa155 
…roj#22421)

Signed-off-by: linghaoSu <[email protected]>
Hapshanko pushed a commit to Hapshanko/argo-cd that referenced this pull request Apr 29, 2025
@linghaoSu @Hapshanko
fix(ui): use correct monaco editor config for correct behavior (argop…
846e411 
…roj#22421)

Signed-off-by: linghaoSu <[email protected]>
Signed-off-by: Hapshanko <[email protected]>
@linghaoSu linghaoSu mentioned this pull request May 7, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agaudreault agaudreault agaudreault approved these changes

@nitishfy nitishfy nitishfy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Monaco editor cannot scroll

3 participants

@linghaoSu @agaudreault @nitishfy