fix: UI log viewer 'Show logs since a given time' filed has no effect bug #22330 #22331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ianyc <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
ianyc
changed the title
andrii-korotkov-verkada
approved these changes
Mar 15, 2025
andrii-korotkov-verkada
added
the
ready-for-review
agaudreault
approved these changes
Mar 20, 2025
PaulSonOfLars
pushed a commit
to PaulSonOfLars/argo-cd
that referenced
this pull request
Mar 22, 2025
… bug argoproj#22330 (argoproj#22331) Signed-off-by: ianyc <[email protected]>
Hapshanko
pushed a commit
to Hapshanko/argo-cd
that referenced
this pull request
Apr 29, 2025
… bug argoproj#22330 (argoproj#22331) Signed-off-by: ianyc <[email protected]> Signed-off-by: Hapshanko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug mentioned in #22330 where the value of field 'Show logs since a given time' did not affect the initial content of the log. The root cause of this bug was that the
sinceSecondsfield was always set to 0 when calling the backend API:/api/v1/applications/{name}/logs, resulting in no change in the API response regardless of the selection of field 'Show logs since a given time'.Checklist:
Closes #22330