Skip to content

feat: Refresh settings preodically #22274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Refresh settings preodically #22274

wants to merge 1 commit into from

Conversation

@sivchari
Copy link
Member

@sivchari sivchari commented Mar 10, 2025

close #22231

Use errprs.Checkerror instead of warning logs.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@sivchari sivchari requested a review from a team as a code owner March 10, 2025 04:01
@bunnyshell
Copy link

bunnyshell bot commented Mar 10, 2025 •
edited
Loading

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@sivchari sivchari force-pushed the check-server-secretkey branch from 0b74caf to 7bbbf32 Compare March 11, 2025 08:30
@sivchari sivchari changed the title do crash when the sever secret key is missing fix: do crash when the sever secret key is missing Mar 11, 2025
@sivchari sivchari force-pushed the check-server-secretkey branch 3 times, most recently from 17c5363 to aedacc9 Compare March 23, 2025 04:23
@sivchari sivchari force-pushed the check-server-secretkey branch from aedacc9 to 627b50e Compare April 17, 2025 10:40
@sivchari sivchari changed the title fix: do crash when the sever secret key is missing Refresh settings preodically Apr 17, 2025
@codecov
Copy link

codecov bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 9.52381% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.03%. Comparing base (881448e) to head (627b50e).
⚠️ Report is 834 commits behind head on master.

Files with missing lines Patch % Lines
util/settings/settings.go 0.00% 19 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #22274      +/-   ##
==========================================
+ Coverage   55.88%   56.03%   +0.15%     
==========================================
  Files         343      343              
  Lines       57333    57555     +222     
==========================================
+ Hits        32038    32253     +215     
- Misses      22649    22653       +4     
- Partials     2646     2649       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sivchari sivchari changed the title Refresh settings preodically feat: Refresh settings preodically Apr 17, 2025
@sivchari sivchari mentioned this pull request Apr 18, 2025
Open
3 tasks
@sivchari
Copy link
Member Author

sivchari commented Apr 20, 2025

@crenshaw-dev PTAL 🙏

@sivchari
Copy link
Member Author

sivchari commented Apr 25, 2025

@gdsoumya @blakepettersson PTAL 🙏

@sivchari
Copy link
Member Author

sivchari commented Apr 28, 2025

Hi, @todaywasawesome .
If you have time, PTAL 🙏

@sivchari sivchari mentioned this pull request May 13, 2025
Open
3 tasks
@sivchari sivchari requested a review from crenshaw-dev May 16, 2025 04:48
@sivchari sivchari self-assigned this May 16, 2025
@sivchari sivchari added the ready-for-review An approver should give a final review and merge the PR label May 30, 2025
@github-project-automation github-project-automation bot moved this to Ready for final review in Argo CD Review May 30, 2025
@agaudreault agaudreault added this to the v3.2 milestone Jun 17, 2025
schraax
schraax reviewed Oct 3, 2025
View reviewed changes
util/settings/settings.go
log.Warnf("Error refreshing settings: %v", err)
continue
}
mgr.notifySubscribers(cdSettings)
Copy link
Contributor

@schraax schraax Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a bad feeling here, if this somehow wil restart the controller in every loop. E.G our controller takes 20 mins to reload...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crenshaw-dev crenshaw-dev Awaiting requested review from crenshaw-dev

2 more reviewers

@schraax schraax schraax left review comments

@beligh-hamdi beligh-hamdi beligh-hamdi approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@sivchari sivchari

Labels

ready-for-review An approver should give a final review and merge the PR

Projects

Argo CD Review
Status: Ready for final review

Milestone

v3.2

Development

Successfully merging this pull request may close these issues.

application-controller and argocd-server do not restart upon "server.secretkey is missing" failure

4 participants

@sivchari @beligh-hamdi @schraax @agaudreault