Skip to content

Conversation

@afzal442
Copy link
Contributor

@afzal442 afzal442 commented Feb 27, 2025

Closes: #21983

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@afzal442 afzal442 requested a review from a team as a code owner February 27, 2025 14:15
@bunnyshell
Copy link

bunnyshell bot commented Feb 27, 2025

❗ Preview Environment undeploy from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to try again to remove the environment

@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.88%. Comparing base (43e5941) to head (9a8c7a5).
⚠️ Report is 734 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22054      +/-   ##
==========================================
- Coverage   55.88%   55.88%   -0.01%     
==========================================
  Files         343      343              
  Lines       57307    57307              
==========================================
- Hits        32027    32026       -1     
- Misses      22631    22637       +6     
+ Partials     2649     2644       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev
Copy link
Member

Thanks, @afzal442! Are you able to run a test in your fork to show that the new config works as expected?

Copy link
Contributor

@andrii-korotkov-verkada andrii-korotkov-verkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Nitish's comment

Signed-off-by: Afzal Ansari <[email protected]>
@afzal442 afzal442 force-pushed the add-renovate-redis-ha branch from 9def14b to cb4d20a Compare March 11, 2025 08:53
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you share an output for what Michael asked?

#22054 (comment)

@afzal442
Copy link
Contributor Author

Still on it. afzal442#2 As I test out locally, and I fetch changes on my origin repo, gets reflected to the upstream repo, that's why you saw unrelated changes.

@afzal442
Copy link
Contributor Author

@crenshaw-dev crenshaw-dev merged commit aefa93f into argoproj:master May 20, 2025
26 of 27 checks passed
crenshaw-dev added a commit that referenced this pull request May 20, 2025
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 24, 2025
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 24, 2025
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Renovate to update redis-ha chart

4 participants