Skip to content

feat(ui): support delete all expired token in project roles #21782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2025
Merged

feat(ui): support delete all expired token in project roles #21782

merged 3 commits into from
May 7, 2025

Conversation

@linghaoSu
Copy link
Member

@linghaoSu linghaoSu commented Feb 5, 2025

Closes #21640

Added a label for expired tokens and a button to quickly delete all expired tokens.

After

clear-tokens.mp4

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@linghaoSu linghaoSu requested a review from a team as a code owner February 5, 2025 08:05
@bunnyshell
Copy link

bunnyshell bot commented Feb 5, 2025 •
edited
Loading

❗ Preview Environment undeploy from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to try again to remove the environment

@andrii-korotkov-verkada andrii-korotkov-verkada added the ready-for-review An approver should give a final review and merge the PR label Feb 7, 2025
@agaudreault agaudreault merged commit ceec669 into argoproj:master May 7, 2025
23 checks passed
@linghaoSu linghaoSu mentioned this pull request May 7, 2025
Closed
6 tasks
@linghaoSu linghaoSu deleted the feat/expired-token-mark branch May 8, 2025 01:52
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 10, 2025
@linghaoSu @LyhengTep
feat(ui): support delete all expired token in project roles (argoproj…
35b466c 
…#21782)

Signed-off-by: linghaoSu <[email protected]>
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
@linghaoSu @ranakan19
feat(ui): support delete all expired token in project roles (argoproj…
e57e525 
…#21782)

Signed-off-by: linghaoSu <[email protected]>
Signed-off-by: Kanika Rana <[email protected]>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
@linghaoSu @olivergondza
feat(ui): support delete all expired token in project roles (argoproj…
024d2be 
…#21782)

Signed-off-by: linghaoSu <[email protected]>
Signed-off-by: Oliver Gondža <[email protected]>
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
@linghaoSu @tylerrosnett
feat(ui): support delete all expired token in project roles (argoproj…
ee9efe4 
…#21782)

Signed-off-by: linghaoSu <[email protected]>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@linghaoSu @chansuke
feat(ui): support delete all expired token in project roles (argoproj…
5b5fef4 
…#21782)

Signed-off-by: linghaoSu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agaudreault agaudreault agaudreault approved these changes

+1 more reviewer

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-for-review An approver should give a final review and merge the PR

Projects

Argo CD Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a "Delete Expired" button the UI project role page

3 participants

@linghaoSu @agaudreault @andrii-korotkov-verkada