Skip to content

Conversation

@korsar182
Copy link
Contributor

Fixes #21080

@korsar182 korsar182 requested a review from a team as a code owner January 4, 2025 20:01
@bunnyshell
Copy link

bunnyshell bot commented Jan 4, 2025

❗ Preview Environment undeploy from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to try again to remove the environment

Copy link
Member

@reggie-k reggie-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Could you add a screenshot of how it looks after the change?
And could you rename the chore in the PR name to fix(ui)?

@korsar182 korsar182 changed the title chore: make Name column wider (argoproj#21080) fix(ui): make Name column wider (argoproj#21080) Jan 6, 2025
@korsar182 korsar182 marked this pull request as draft January 6, 2025 14:25
@korsar182 korsar182 marked this pull request as ready for review January 6, 2025 16:59
@korsar182
Copy link
Contributor Author

After the change it looks like this. Not the best, but seems better, then current state
image

@surajyadav1108
Copy link
Member

DCO check is failing. Please sign off your commits. You can check the details in the DCO

@0xDones
Copy link

0xDones commented Mar 3, 2025

Hey folks, can we move forward with this?

@0xDones
Copy link

0xDones commented May 2, 2025

@korsar182 @reggie-k @surajyadav1108 bumping this issue once more.

@codecov
Copy link

codecov bot commented Jun 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@e66068c). Learn more about missing BASE report.
Report is 760 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #21375   +/-   ##
=========================================
  Coverage          ?   60.07%           
=========================================
  Files             ?      342           
  Lines             ?    58814           
  Branches          ?        0           
=========================================
  Hits              ?    35330           
  Misses            ?    20622           
  Partials          ?     2862           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Oleksandr Tkachenko <[email protected]>
@korsar182
Copy link
Contributor Author

korsar182 commented Jun 15, 2025

@surajyadav1108
DCO check now passed

@surajyadav1108
Copy link
Member

looks okay in Screenshot. LGTM!

@korsar182
Copy link
Contributor Author

On the current v3.0.6 version
image

@agaudreault agaudreault merged commit 590d0cd into argoproj:master Jun 17, 2025
24 checks passed
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
Mangaal pushed a commit to Mangaal/argo-cd that referenced this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make "name" column wider

5 participants