Skip to content

fix(ui): Added tooltip for buttons in narrow window #20886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2025
Merged

fix(ui): Added tooltip for buttons in narrow window #20886

merged 3 commits into from
May 7, 2025

Conversation

@surajyadav1108
Copy link
Member

@surajyadav1108 surajyadav1108 commented Nov 21, 2024 •
edited
Loading

can close this

issue #5621

narrorw.mp4

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@surajyadav1108 surajyadav1108 requested a review from a team as a code owner November 21, 2024 10:52
@bunnyshell
Copy link

bunnyshell bot commented Nov 21, 2024 •
edited
Loading

❗ Preview Environment undeploy from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to try again to remove the environment

@surajyadav1108 surajyadav1108 changed the title fix(ui) : Added tooltip for buttons in narrow window (ui-polish). fix(ui): Added tooltip for buttons in narrow window (ui-polish). Nov 21, 2024
@andrii-korotkov-verkada andrii-korotkov-verkada added the ready-for-review An approver should give a final review and merge the PR label Nov 21, 2024
@crenshaw-dev crenshaw-dev changed the title fix(ui): Added tooltip for buttons in narrow window (ui-polish). fix(ui): Added tooltip for buttons in narrow window Nov 21, 2024
rumstead
rumstead approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@rumstead rumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@surajyadav1108 surajyadav1108 mentioned this pull request Dec 4, 2024
Closed
6 tasks
@agaudreault agaudreault merged commit 38e7a03 into argoproj:master May 7, 2025
23 checks passed
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 10, 2025
@surajyadav1108 @LyhengTep
fix(ui): Added tooltip for buttons in narrow window (argoproj#20886)
45f0db8 
Signed-off-by: Surajyadav <[email protected]>
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
@surajyadav1108 @ranakan19
fix(ui): Added tooltip for buttons in narrow window (argoproj#20886)
20c6443 
Signed-off-by: Surajyadav <[email protected]>
Signed-off-by: Kanika Rana <[email protected]>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
@surajyadav1108 @olivergondza
fix(ui): Added tooltip for buttons in narrow window (argoproj#20886)
5cf6f42 
Signed-off-by: Surajyadav <[email protected]>
Signed-off-by: Oliver Gondža <[email protected]>
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
@surajyadav1108 @tylerrosnett
fix(ui): Added tooltip for buttons in narrow window (argoproj#20886)
2554342 
Signed-off-by: Surajyadav <[email protected]>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@surajyadav1108 @chansuke
fix(ui): Added tooltip for buttons in narrow window (argoproj#20886)
4edc1e9 
Signed-off-by: Surajyadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rumstead rumstead rumstead approved these changes

+1 more reviewer

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-for-review An approver should give a final review and merge the PR

Projects

Argo CD Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@surajyadav1108 @rumstead @andrii-korotkov-verkada @agaudreault