-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: Automate Triggering of trigger-release.sh After Init Release GitHub Action #20323 #20560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
❗ Preview Environment undeploy from Bunnyshell failedSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
.github/workflows/init-release.yaml
Outdated
| signoff: true | ||
| labels: release | ||
|
|
||
| trigger-release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be executed after init-release PR is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created a new workflow file. PTAL!
|
Thank you @jaehanbyun for taking it, left small comment |
…tHub Action Signed-off-by: jaehanbyun <[email protected]>
7e2dded to
f6c7bea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20560 +/- ##
=========================================
Coverage ? 55.12%
=========================================
Files ? 324
Lines ? 55116
Branches ? 0
=========================================
Hits ? 30384
Misses ? 22114
Partials ? 2618 ☔ View full report in Codecov by Sentry. |
|
Thank you, from first glance it looks good, lets discuss it on contribution meeting, and probably we will merge it after 2.13 GA release Also @34fathombelow should review it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only nit is to update the release docs and mention that Step 2 is now automated.
https://github.com/argoproj/argo-cd/blob/master/docs/developer-guide/releasing.md
Signed-off-by: jaehanbyun <[email protected]>
|
@pasha-codefresh, do you still have concerns about this PR? |
|
@pasha-codefresh, Could you please confirm once again if this PR can now be merged? |
|
We just need test it on fork and make sure that it works properly |
Closes: #20323
Checklist:
What I have done:
According to the existing documentation, in Step 2 - Tag Release Branch of the release process, developers are required to manually execute the
trigger-release.shscript. This manual step introduces the potential for human error, such as entering the wrong version number or working on the incorrect branch.To mitigate these risks, I have automated this step by adding a new job called
trigger-releaseto theinit-release.yamlworkflow. This job automatically executes thetrigger-release.shscript after theprepare-releasejob completes. By doing so, the release process becomes fully automated, eliminating the need for manual script execution and reducing the likelihood of human errors.