fix: make copies of ReplicaSets / Pods to avoid clash with grouped code #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Eftimie <[email protected]>
Contributor
Author
|
fyi: @rbreeze / @zachaller |
Closed
zachaller
approved these changes
Jan 16, 2023
|
@zachaller, Can we get a release for this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #10
Signed-off-by: Alex Eftimie [email protected]
I noticed that whenever I'm in a grouped view (for instance Node view) and open the extension, the main website gets poluted with invalid pods (no metadata, just objectMeta) which results inevitably in a crash like this:
With this change, I'm using copies of the RS and Pod objects so that they are not tainted in CD.