Parse workloadRef from tree so we can populate containers #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Eftimie <[email protected]>
Signed-off-by: Alex Eftimie <[email protected]>
rbreeze
approved these changes
Oct 21, 2022
Contributor
Author
|
We decided not to continue with workloadRef, so I won't be picking this up. |
|
Hi @alexef , Sorry for commenting on the close PR as I was following on the issue #2. Could you please tell me what you mean by "We decided not to continue with workloadRef"? Does it mean that |
Contributor
Author
|
Hi @ngoduykhanh, sorry for the ambiguity. No, afaik, workloadRef is and will be supported by Argo Rollout. My comment was only related to the my company's focus, as we don't use workloadRef ourselves, I couldn't invest more time into this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the container view is not empty (when using workloadRef).
Continuation of: #18
LE: this doesn't work, as the ApplicationTree stores only metadata, not the Deployment spec. Fetching it would be an additional backend call (https://github.com/argoproj/argo-cd/blob/master/ui/src/app/shared/services/applications-service.ts#L275). However, for this call we need to know the "applicationNamespace" which is also not exposed to the extension.