Skip to content

fix: access undefined spec.template when using workloadRef #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2022
Merged

fix: access undefined spec.template when using workloadRef #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ui/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const parseInfoFromResourceNode = (
const steps = spec.strategy?.canary?.steps || [];
ro.steps = steps;

if (status.currentStepIndex && steps.length > 0) {
if (steps && status.currentStepIndex && steps.length > 0) {
ro.step = `${status.currentStepIndex}/${steps.length}`;
}

Expand All @@ -49,8 +49,10 @@ const parseInfoFromResourceNode = (
}

ro.containers = [];
for (const c of spec.template?.spec?.containers) {
ro.containers.push({ name: c.name, image: c.image });
if (spec.template) {
for (const c of spec.template?.spec?.containers) {
ro.containers.push({ name: c.name, image: c.image });
}
}

ro.current = status.replicas;
Expand All @@ -64,8 +66,8 @@ const parseCurrentCanaryStep = (
): { currentStep: any; currentStepIndex: number } => {
const { status, spec } = resource;
const canary = spec.strategy?.canary;
if (!canary || canary.steps.length === 0) {
return null;
if (!canary || !canary.steps || canary.steps.length === 0) {
return { currentStep: null, currentStepIndex: -1 };
}
let currentStepIndex = 0;
if (status.currentStepIndex) {
Expand Down