Parse AnalysisRuns to improve UI #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvgmb
commented
Jun 1, 2022
Comment on lines
+130
to
+141
| const parseAnalysisRunStatus = (status: string): string => { | ||
| switch(status) { | ||
| case 'Healthy': | ||
| return 'Successful'; | ||
| case 'Progressing': | ||
| return 'Running'; | ||
| case 'Degraded': | ||
| return 'Failure'; | ||
| default: | ||
| return 'Error'; | ||
| } | ||
| } |
There was a problem hiding this comment.
parseAnalysisRunStatus function converts Argo CD status to Argo Rollouts' Analysis Run status.
httin
approved these changes
Sep 13, 2022
|
How does this relates with: argoproj/argo-rollouts#1910 ? as 1.3.0 just got released, I don't feel I understand the exact relationship between that and this extension. Does the extension get the changes automatically? Or is the extension a completely separate UI that hooks into CD? |
|
Answered myself, the newly introduced view will be fed with data from argocd, as soon as this pr is merged. |
alexef
approved these changes
Sep 28, 2022
zachaller
approved these changes
Oct 5, 2022
leoluz
approved these changes
Oct 5, 2022
|
@rbreeze any chance this can be merged 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse AnalysisRun to take advantage of existing UI elements.
Before:
After:
