Skip to content

Conversation

@shaxbee
Copy link
Contributor

@shaxbee shaxbee commented Jul 24, 2025

What type of PR is this?

/kind bug

What does this PR do / why we need it:

  • AppProject RBAC supports applicationsets resource, added it to ProjectRule resources enum.
  • Image tag was hardcoded and therefore was not reflecting advertised appVersion.
  • AppProject watch verb was missing from the manager-role, causing:
E0724 08:36:33.277387       1 reflector.go:166] "Unhandled Error" err="pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:251: Failed to watch *v1alpha1.AppProject: appprojects.argoproj.io is forbidden: User \"system:serviceaccount:argocd:argocd-rbac-operator-controller-manager\" cannot watch resource \"appprojects\" in API group \"argoproj.io\" at the cluster scope" logger="UnhandledError"

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

@shaxbee shaxbee force-pushed the fix/argocdprojectrole-applicationset-resource branch from f03d80f to a926a62 Compare July 24, 2025 08:42
Zibi Mandziejewicz added 2 commits July 24, 2025 17:44
@shaxbee shaxbee force-pushed the fix/argocdprojectrole-applicationset-resource branch from a926a62 to b23a1d4 Compare July 24, 2025 08:44
Copy link
Collaborator

@ggkhrmv ggkhrmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @shaxbee!

@ggkhrmv ggkhrmv merged commit fcd4e56 into argoproj-labs:main Jul 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants