Skip to content

Conversation

@k4r1
Copy link
Contributor

@k4r1 k4r1 commented Jun 27, 2025

What type of PR is this?
/kind enhancement

What does this PR do / why we need it:
Allows specifying tolerations in the helm chart.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

How to test changes / Special notes to the reviewer:

From helm/argocd-rbac-operator:

helm template -f values.test.yaml .

With e.g. values.test.yaml

tolerations:
- key: "key1"
  operator: "Equal"
  value: "value1"
  effect: "NoSchedule"

Observe in the rendered output that the tolerations are included in the spec.

@k4r1 k4r1 force-pushed the feat/tolerations branch from ac554b9 to 1d21922 Compare June 27, 2025 15:39
@ggkhrmv
Copy link
Collaborator

ggkhrmv commented Jul 2, 2025

Hi @k4r1 LGTM, thank you for the contribution :)

@ggkhrmv ggkhrmv merged commit b6a2e20 into argoproj-labs:main Jul 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants