Skip to content

Conversation

@jgwest
Copy link
Member

@jgwest jgwest commented Apr 11, 2025

What type of PR is this?
/kind enhancement

What does this PR do / why we need it:

We're using an extremely old version of prometheus-operator, which does not contain some of the more recent changes in the various Prometheus operator CRDs.

This PR upgrades to a newer prometheus-operator operator version which I picked so that it should be as compatible as possible with our other dependencies (same go version, same controller-runtime version, compatible kubernetes version).

@jgwest jgwest force-pushed the deprecate-coreos-prom-operator-april-2025 branch from b745b35 to c8d1803 Compare April 14, 2025 05:26
@jgwest jgwest force-pushed the deprecate-coreos-prom-operator-april-2025 branch from c8d1803 to 2f93f2d Compare April 14, 2025 06:10
Copy link
Collaborator

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jgwest
Copy link
Member Author

jgwest commented Apr 24, 2025

Thanks @chetan-rns!

@jgwest jgwest merged commit d0b8ed3 into argoproj-labs:master Apr 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants