Skip to content
This repository was archived by the owner on Oct 19, 2024. It is now read-only.
This repository was archived by the owner on Oct 19, 2024. It is now read-only.

Should make argocd-notifications-secret to an optional argument #428

@kumo-rn5s

Description

@kumo-rn5s

Summary

For webhooks that do not use secrets(like discord),
the notification controller should not detect the existence of argocd-notifications-secret

Diagnostics

My environment:
EKS 1.22
Argocd v2.4.11+3d9e9f2
Argocd notifications v1.2.1

This is the log without argocd-notifications-secret applied

time="2022-09-08T14:01:23Z" level=info msg="Start processing" resource=argocd/app
time="2022-09-08T14:01:23Z" level=error msg="Failed to process: secret \"argocd-notifications-secret\" not found" resource=argocd/app

After adding a empty secret

apiVersion: v1
kind: Secret
metadata:
  name: argocd-notifications-secret
type: Opaque

The controller is available immediately

time="2022-09-08T14:01:23Z" level=info msg="Start processing" resource=argocd/app
time="2022-09-08T14:01:23Z" level=info msg="Processing skipped: sync status out of date" resource=argocd/app

I have just used argocd for a short time, so please correct me if my description is technically incorrect.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions