Skip to content

Conversation

@ishitasequeira
Copy link
Collaborator

@ishitasequeira ishitasequeira commented Jan 7, 2025

Move references for kube, image, registry to registry-scanner.

Some additional details about breaking out pkg/kube package:
The current pkg/kube in argocd-image-updater references the Application Object which is specific to ArgoCD, I updated the KubernetesClient as below:

type ImageUpdaterKubernetesClient struct {
	ApplicationsClientset versioned.Interface
	KubeClient            *kube.KubernetesClient
}

where, KubernetesClient is as below:

type KubernetesClient struct {
Clientset kubernetes.Interface
Context context.Context
Namespace string
}

@ishitasequeira ishitasequeira force-pushed the replace-pkg-registry-package branch from 6e9e39c to ff378c4 Compare January 7, 2025 13:11
Signed-off-by: Ishita Sequeira <[email protected]>
@ishitasequeira ishitasequeira marked this pull request as ready for review January 7, 2025 13:16
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 63.42%. Comparing base (5ae9a45) to head (6728e9f).

Files with missing lines Patch % Lines
cmd/test.go 0.00% 3 Missing ⚠️
pkg/kube/kubernetes.go 40.00% 3 Missing ⚠️
cmd/run.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
- Coverage   72.07%   63.42%   -8.66%     
==========================================
  Files          25       15      -10     
  Lines        3653     2212    -1441     
==========================================
- Hits         2633     1403    -1230     
+ Misses        880      723     -157     
+ Partials      140       86      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ishita Sequeira <[email protected]>
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chengfang chengfang merged commit 1a998b1 into argoproj-labs:master Jan 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants