Update references of cache, env, health to use modules from registry-scanner #972
Conversation
…scanner Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Ishita Sequeira <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #972 +/- ##
==========================================
- Coverage 72.44% 71.99% -0.46%
==========================================
Files 27 24 -3
Lines 3727 3642 -85
==========================================
- Hits 2700 2622 -78
+ Misses 885 880 -5
+ Partials 142 140 -2 ☔ View full report in Codecov by Sentry. |
ishitasequeira
changed the title
ishitasequeira
requested review from
chengfang,
jannfis and
pasha-codefresh
as code owners
| "github.com/argoproj-labs/argocd-image-updater/pkg/version" | ||
| "github.com/argoproj-labs/argocd-image-updater/registry-scanner/pkg/env" | ||
| "github.com/argoproj-labs/argocd-image-updater/registry-scanner/pkg/health" | ||
| "github.com/argoproj-labs/argocd-image-updater/registry-scanner/pkg/log" |
There was a problem hiding this comment.
Is the health server referenced by registry-scanner for it to be relocated?
There was a problem hiding this comment.
It is not. Do you feel we should keep it in image-updater itself?
There was a problem hiding this comment.
Yeah, since it's checks the health of argocd-image-updater, and it won't be able to run within registry-scanner. We can address that in a separate PR.
| const DefaultTargetFilePattern = ".argocd-source-%s_%s.yaml" | ||
| const DefaultTargetFilePatternWithoutNamespace = ".argocd-source-%s.yaml" | ||
| const DefaultHelmValuesFilename = "values.yaml" | ||
|
|
There was a problem hiding this comment.
I see both image-updater and registry-scanner have constants.go. Do we want to keep only fields required by registry-scanner in registry-scanner/constants.go, and remove those not used by registry-scanner?
There was a problem hiding this comment.
Yes, I am working on a logic to separate them out. It needs a bit of refactoring. I will have the PR updated.
There was a problem hiding this comment.
I will move this change to a different PR.
Signed-off-by: Ishita Sequeira <[email protected]>
3 participants
Update references of cache, env, health to use modules from registry-scanner