refactor: Add registry scanner module #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishitasequeira
requested review from
chengfang,
jannfis and
pasha-codefresh
as code owners
ishitasequeira
force-pushed
the
add-registry-scanner
branch
from
fd738b7 to
895cb73
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #890 +/- ##
=======================================
Coverage 74.82% 74.82%
=======================================
Files 31 31
Lines 3912 3912
=======================================
Hits 2927 2927
Misses 850 850
Partials 135 135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Ishita Sequeira <[email protected]>
ishitasequeira
force-pushed
the
add-registry-scanner
branch
from
2b083c3 to
d782f60
Compare
jannfis
reviewed
Oct 21, 2024
registry-scanner/README.md
Outdated
Comment on lines
12
to
21
| Registry Scanner is under active development. We would not recommend it | ||
| yet for *critical* production workloads, but feel free to give it a spin. | ||
|
|
||
| We're very interested in feedback on usability and the user experience as well | ||
| as in bug discoveries and enhancement requests. | ||
|
|
||
| **Important note:** Until the first stable version (i.e. `v1.0`) is released, | ||
| breaking changes between the releases must be expected. We will do our best | ||
| to indicate all breaking changes (and how to un-break them) in the | ||
| [Changelog](CHANGELOG.md) |
Contributor
There was a problem hiding this comment.
I'd replace this by a statement that this component is not yet ready for public consumption, and that we're currently working on a first release.
registry-scanner/LICENSE
Outdated
| same "printed page" as the copyright notice for easier | ||
| identification within third-party archives. | ||
|
|
||
| Copyright [yyyy] [name of copyright owner] |
Contributor
There was a problem hiding this comment.
Suggested change
| Copyright [yyyy] [name of copyright owner] | |
| Copyright 2024 The Argo CD Image Updater authors |
Collaborator
Author
There was a problem hiding this comment.
I see this to be same in Image Updater.. Should I update it their as well?
Signed-off-by: Ishita Sequeira <[email protected]>
jannfis
approved these changes
Oct 22, 2024
jannfis
changed the title
Tchoupinax
pushed a commit
to Tchoupinax/argocd-image-updater
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Ishita Sequeira <[email protected]> Signed-off-by: Tchoupinax <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image Updater provides some functionality that can be reused by other projects, most notably the feature to inspect OCI and Docker registries' contents and pick an image based on some constraints.
This PR starts the initial setup of a new module named
registry-scannerto separate out the functionality of registry scanning and fetching images into a library. This allows users to pull in just the registry scanning functionality and not pull in the entire image updater for use.Future Tasks:
pkg/folders to registry-scanner baring the argo-cd functionalityregistry-scannerwith argocd-image-updaterregistry-scanneras part of release process.