Skip to content

Conversation

@chengfang
Copy link
Collaborator

@chengfang chengfang commented Sep 5, 2024

Fixes #711

  • change WantsPlatform() method to allow match of broader platform
  • add unit tests for the above change
  • improve logs to include platform variant so it's clear why certain match is false
  • this fix causes some change of behavior in comparing options platforms vs platforms of available images, as shown in the changes to pkg/image/options_test.go

…quirement for a broader image platform os/arch

Signed-off-by: Cheng Fang <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.48%. Comparing base (40f260a) to head (2e4b9c0).

Files with missing lines Patch % Lines
pkg/registry/client.go 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
+ Coverage   73.43%   73.48%   +0.05%     
==========================================
  Files          31       31              
  Lines        3136     3142       +6     
==========================================
+ Hits         2303     2309       +6     
  Misses        695      695              
  Partials      138      138              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great stuff!

@jannfis jannfis merged commit e1cc998 into argoproj-labs:master Sep 6, 2024
Tchoupinax pushed a commit to Tchoupinax/argocd-image-updater that referenced this pull request Oct 23, 2024
…quirement for a broader image platform os/arch (argoproj-labs#858)

Signed-off-by: Cheng Fang <[email protected]>
Signed-off-by: Tchoupinax <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ArgoCD does not consider images for arch "linux/arm64/v8"

3 participants