Skip to content

fix: failed to process a full image-spec annotation with git writeback to helmvalues #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: failed to process a full image-spec annotation with git writeback to helmvalues #843

merged 1 commit into from
Sep 6, 2024

Conversation

@chengfang
Copy link
Collaborator

@chengfang chengfang commented Aug 27, 2024

Fixes #840

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.50%. Comparing base (5990a9b) to head (25d55fa).
Report is 114 commits behind head on master.

Files with missing lines Patch % Lines
pkg/argocd/update.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
+ Coverage   73.48%   73.50%   +0.01%     
==========================================
  Files          31       31              
  Lines        3142     3144       +2     
==========================================
+ Hits         2309     2311       +2     
  Misses        695      695              
  Partials      138      138

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jannfis
jannfis approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis
Copy link
Contributor

jannfis commented Sep 6, 2024

@chengfang can you please resolve the conflict?

@chengfang chengfang changed the title fix: Could not update application spec: could not find an image-tag annotation for image fix: failed to process a full image-spec annotation with git writeback to helmvalues Sep 6, 2024
@chengfang chengfang merged commit 79de6d5 into argoproj-labs:master Sep 6, 2024
Tchoupinax pushed a commit to Tchoupinax/argocd-image-updater that referenced this pull request Oct 23, 2024
@chengfang @Tchoupinax
fix: failed to process a full image-spec annotation with git writebac…
bfb23a6 
…k to helmvalues (argoproj-labs#843)

Signed-off-by: Cheng Fang <[email protected]>
Signed-off-by: Tchoupinax <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jannfis jannfis jannfis approved these changes

@pasha-codefresh pasha-codefresh Awaiting requested review from pasha-codefresh pasha-codefresh is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Could not update application spec: could not find an image-tag annotation for image

3 participants

@chengfang @codecov-commenter @jannfis