Skip to content

Conversation

@kostis-codefresh
Copy link
Contributor

Explain how to make releases for Argo Image updater

Signed-off-by: Kostis Kapelonis <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.53%. Comparing base (65698c5) to head (2306aef).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #827   +/-   ##
=======================================
  Coverage   73.53%   73.53%           
=======================================
  Files          31       31           
  Lines        3140     3140           
=======================================
  Hits         2309     2309           
  Misses        695      695           
  Partials      136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh
Copy link
Collaborator

@jannfis @chengfang could you please also review it? I want make sure that process is clear

https://argocd-image-updater--827.org.readthedocs.build/en/827/contributing/releasing/

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks so much!

I made some observations, please see below.

Comment on lines +21 to +25
Finally run

```
./hack/create-release-pr.sh origin
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be noted that this script needs the GitHub CLI. It also uses something called semver-cli, which I've never heard of.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the requirements in the documentation page itself.

Signed-off-by: Kostis Kapelonis <[email protected]>
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jannfis jannfis merged commit 1c5a2ff into argoproj-labs:master Aug 14, 2024
Tchoupinax pushed a commit to Tchoupinax/argocd-image-updater that referenced this pull request Oct 23, 2024
Signed-off-by: Kostis Kapelonis <[email protected]>
Signed-off-by: Tchoupinax <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants